Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing bounds checks #13

Closed
wintersteiger opened this issue Jun 15, 2022 · 0 comments
Closed

Add missing bounds checks #13

wintersteiger opened this issue Jun 15, 2022 · 0 comments

Comments

@wintersteiger
Copy link
Contributor

wintersteiger commented Jun 15, 2022 •
edited
Loading

Spotted by @fournet:

merklecpp/merklecpp.h

Line 85 in 71bc435

r |= static_cast<uint64_t>(bytes[index++]) << (8 * (sz - i - 1));

We need to add bounds checks here, or use .at() instead of operator[].
wintersteiger added a commit to wintersteiger/merklecpp that referenced this issue Oct 5, 2022
@wintersteiger
Add more generous vector bounds checks. Fixes microsoft#13.
fe887aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wintersteiger