Update Window_and_Application_API_Spec.md #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know what the property should be called there, but definitely not Visible. :-)
dotMorten
reviewed
Mar 16, 2020
| ```CS | ||
| public Size Visible { get; } | ||
| public Size WindowSize { get; } |
There was a problem hiding this comment.
Yes, I thought about that too. But maybe when you have an event handler and the parameter is just called "e", e.WindowSize looks better than e.Size. But I'm not an API design expert. :-)
There was a problem hiding this comment.
Then the other size changed event should be called ControlSize. It's more consistent just calling it Size.
Also don't see why we can't reuse the existing SizeChangedEventArgs class here?
There was a problem hiding this comment.
Ok, changed to just Size.
Yes, the question with SizeChangedEventArgs is good. @marb2000 might know. :)
Change WindowSize to just Size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what the property should be called there, but definitely not Visible. :-)