Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Window_and_Application_API_Spec.md #72

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Update Window_and_Application_API_Spec.md #72

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d418e0
Update Window_and_Application_API_Spec.md
thomasclaudiushuber Mar 16, 2020
77695ce
Update Window_and_Application_API_Spec.md
thomasclaudiushuber Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions active/Win32/Window_and_Application_API_Spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,9 @@ Contains the argument returned by a window size change event.
public bool Handled { get; set; };
```

- WindowSizeChangedEventArgs.Visible: Gets the new size of the window in units of effective (view) pixels.
- WindowSizeChangedEventArgs.WindowSize: Gets the new size of the window in units of effective (view) pixels.
```CS
public Size Visible { get; }
public Size WindowSize { get; }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer just Size

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought about that too. But maybe when you have an event handler and the parameter is just called "e", e.WindowSize looks better than e.Size. But I'm not an API design expert. :-)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the other size changed event should be called ControlSize. It's more consistent just calling it Size.
Also don't see why we can't reuse the existing SizeChangedEventArgs class here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, changed to just Size.

Yes, the question with SizeChangedEventArgs is good. @marb2000 might know. :)

```


Expand Down