ListViewItem selected state looks broken

[FrayxRulez]

Describe the bug

ListViewItem selected pointer over state looks quite broken on WinUI 2.6, on 21H1.

Steps to reproduce the bug

Steps to reproduce the behavior:

1. Select a ListViewItem.
2. Move the mouse in and out of it.

Screenshots

1INtaSb2f6.mp4

Version Info

NuGet package version:

Microsoft.UI.Xaml 2.6.0

Windows 10 version	Saw the problem?
Insider Build (xxxxx)
May 2021 Update (19043)	Yes
May 2020 Update (19041)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)

Device form factor	Saw the problem?
Desktop	Yes
Xbox
Surface Hub
IoT

[StephenLPeters]

@ranjeshj this is close to maybe wanting to cherry pick into 2.6 thoughts?

@marksfoster do you know the intended behavior? is the selected rest state supposed to be accent color or the selected pointer over state supposed to be a grey?

[lhak]

Please also change the way selected items (without pointer over) are presented. The selected state is barely visible (low contrast).

[roxk]

Any chance the new list view selected style with selected indicator (pill) can be ported from WUXC to MUXC so it works on windows 10 as well? While porting WinUI 2.6 styles to WinUI 3, I found that the new list view selected style isn't in MUXC so I couldn't port it on my own.

Since navigation view's selected indicator works similarly and is already working on windows 10 (as seen in control gallery), this should be feasible. If that selected indicator expanding animation is not possible, IMO MUXC should at least make it work like tree view's selected state, whose selected indicator is static.

WinUI 2.6 in general looks great on both windows 10 and 11, and right now this is the only show-stopper that makes the migration to the new visual style incomplete. For what it's worth, in list view's multiple selection mode in WinUI 2.6, the checkbox is outright just WinUI 2.5 style and looks very visually inconsistent with all other beautiful controls:

There are some evidence which makes me think this selected state is incomplete/not working as intended, as outdated resources, such as checkbox theme resources, are used:

microsoft-ui-xaml/dev/CommonStyles/ListViewItem_themeresources.xaml

Line 849 in 0b2e250

Fill="{ThemeResource CheckBoxBackgroundThemeBrush}"

microsoft-ui-xaml/dev/CommonStyles/ListViewItem_themeresources_21h1.xaml

Line 943 in 0b2e250

Fill="{ThemeResource CheckBoxBackgroundThemeBrush}"

[ranjeshj]

@beervoley closing this since the change is merged.

[lmadhavan]

Will this be hotfixed to 2.6?

[StephenLPeters]

Yes.