ListView: fix list view selected hover #5448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beervoley
added
area-Lists
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beervoley
commented
Jul 13, 2021
| @@ -130,7 +130,7 @@ | |||
| <StaticResource x:Key="ListViewItemBackgroundPointerOver" ResourceKey="SubtleFillColorSecondaryBrush" /> | |||
| <StaticResource x:Key="ListViewItemBackgroundPressed" ResourceKey="SubtleFillColorTertiaryBrush" /> | |||
| <StaticResource x:Key="ListViewItemBackgroundSelected" ResourceKey="SubtleFillColorSecondaryBrush" /> | |||
| <StaticResource x:Key="ListViewItemBackgroundSelectedPointerOver" ResourceKey="AccentFillColorSecondaryBrush" /> | |||
There was a problem hiding this comment.
@marksfoster could you please confirm that we indeed need to use SubtleFillColorSecondaryBrush instead of accent color here?:)
And what is the expected color of the selected item in rest: is it accent or subtleFillColorSecodary?
|
Closing: decision has not been made yet |
StephenLPeters
removed
the
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5304.
Motivation and Context
Hover color was different in Light and Dark theme for the ListViewItem. This PR fixes it.
How Has This Been Tested?
Manually.