Fix a SplitView pane open/close issue when animations are disabled #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevansaks
added
needs-cherrypicktorelease
jevansaks
approved these changes
Sep 13, 2019
jevansaks
pushed a commit
that referenced
this pull request
Sep 13, 2019
jevansaks
removed
the
needs-cherrypicktorelease
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618
SplitView pane gets stuck after window resizing when animations are disabled.
This is because Storyboard animations won't play when animations are disabled. Moved those animations to visual state setters since they were all just changing values at KeyTime 0:0:0 and not actually animating anything.
Screenshot after fix:
