NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu #3082

Felix-Dev · 2020-08-08T15:38:55Z

Description

This PR sets the corner radius of the NavigationView's dropdown overflow menu in Top mode and of the NavigationViewItem's children flyout menu to the value set by the "OverlayCornerRadius" resource.

Motivation and Context

Fixes #2401.

How Has This Been Tested?

Tested visually and added interaction tests.

Screenshots:

(The children flyout menu.)

(The overflow menu.)

(Note: While it might appear in the screenshots that the flyout border shadow is missing, rest assured it is not.)

test/MUXControlsTestApp/Utilities/VisualTreeUtils.cs

dev/NavigationView/NavigationView_InteractionTests/CommonTests.cs

dev/NavigationView/NavigationView.xaml

StephenLPeters · 2020-08-10T17:40:59Z

dev/NavigationView/NavigationView.xaml

+                                                        <Setter Property="ScrollViewer.VerticalScrollMode" Value="Auto" />
+                                                        <Setter Property="ScrollViewer.VerticalScrollBarVisibility" Value="Auto" />
+                                                        <Setter Property="ScrollViewer.ZoomMode" Value="Disabled" />
+                                                        <contract7Present:Setter Property="CornerRadius" Value="{ThemeResource OverlayCornerRadius}" />


<contract7Present:Setter Property="CornerRadius" Value="{ThemeResource OverlayCornerRadius}" /> [](start = 56, length = 95)

Do we need the contract7NotPresent setter?

We don't need it here because there is nothing really to set it to. The important contract7NotPresent setter is this one:

microsoft-ui-xaml/dev/NavigationView/NavigationView.xaml

Line 317 in b9d5ae1

contract7NotPresent:CornerRadius="{ThemeResource OverlayCornerRadius}"/>

The FlyoutPresenter.CornerRadius API is only available since 1809 so to get rounded corners on earlier Windows 10 versions, we use the contract7NotPresent setter above.

StephenLPeters · 2020-08-10T23:43:03Z

/azp run

azure-pipelines · 2020-08-10T23:43:14Z

Azure Pipelines successfully started running 1 pipeline(s).

Felix-Dev · 2020-08-11T09:22:59Z

@StephenLPeters The failing test - VerifyNavigationViewItemChildrenFlyoutMenuCornerRadius - is the one of the two interaction tests I added with with this PR and runs fine for me locally.

Edit: @chingucoding pointed me to the "Tests" section of Azure Pipelines showing me where the information is listed I previously mentioned.

marcelwgn · 2020-08-11T09:32:09Z

@Felix-Dev You can open the "Tests" tab of that CI run to see more information where the tests failed, and what the logs are:

Felix-Dev · 2020-08-11T09:44:31Z

@chingucoding Very nice, didn't know that! Looks like that shows me exactly the info I was asking for (the Window 10 versions with test failures and log messages about the failing tests themselves).

So...speaking about the test failure. It appears the VerifyNavigationViewItemChildrenFlyoutMenuCornerRadius test fails on RS2 - 1903 with the message:

Error log:
[Warn]: Failed to find and invoke Back button. Error: System.Runtime.InteropServices.COMException (0x80040201): An event was unable to invoke any of the subscribers (Exception from HRESULT: 0x80040201)    at UIAutomationClient.IUIAutomationInvokePattern.Invoke()    at Microsoft.Windows.Apps.Test.Foundation.Patterns.InvokeImplementation.Invoke()    at Microsoft.Windows.Apps.Test.Foundation.Controls.Button.Invoke()    at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common.Wait.ForIdle(Boolean findElementsIfNull)    at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Common.AppsTestExtensions.InvokeAndWait(Button button, Nullable`1 timeout)    at Windows.UI.Xaml.Tests.MUXControls.InteractionTests.Infra.Application.GoBack()
[Error]: Failed to create test app process (Process is null: False) or process exited unexpectedly. Failing the current test and queueing an app restart.
[Error]: Cleanup fixture 'TestCleanup' for the scope 'Windows.UI.Xaml.Tests.MUXControls.InteractionTests.NavigationViewTests.CommonTests.VerifyNavigationViewItemChildrenFlyoutMenuCornerRadius' failed.

What do I make of this? Does it fail because it cannot find the Back button? I do see that Back button error in my local test output as well but it doesn't fail the test (perhaps expected because that error is only specified as a "Warning"):

invoking the back button...
Tried to wait for idle after the test app has closed!
Failed to find and invoke Back button. Error: Microsoft.Windows.Apps.Test.Automation.ElementNotAvailableException: ElementNotAvailable ---> System.Runtime.InteropServices.COMException: An event was unable to invoke any of the subscribers (Exception from HRESULT: 0x80040201)
Clearing element cache which may be stale.
Back button was not found. Trying again (0).
Process already exited
Going to the previous page...
Process already exited
Cleaning up test...
Failed to create test app process (Process is null: False) or process exited unexpectedly. Failing the current test and queueing an app restart.
Test failed. Queueing an app restart, since we may now be in an unknown state.
Test cleanup complete.

Is it possible the test just failed due to bad luck here?

…ts to TopModeTests.

StephenLPeters · 2020-08-11T16:58:47Z

In my experience I've seen the failed to find back button error when taef, the test harness, doesn't connect to the test process correctly. This is sometimes a taef issue, for which we attempt to fix with retry logic. Sometimes this is a test app issue that causes the app to crash before taef has a chance to attach.

StephenLPeters · 2020-08-11T17:01:09Z

/azp run

azure-pipelines · 2020-08-11T17:01:21Z

Azure Pipelines successfully started running 1 pipeline(s).

Felix-Dev · 2020-08-11T20:00:30Z

Same test failure as before. Given that the test runs fine for me locally I'm not sure how much I can do here.

StephenLPeters · 2020-08-18T20:34:55Z

@Felix-Dev can you merge master to pick up the CI build fix that just went in?

Felix-Dev · 2020-08-18T21:23:15Z

Merged with master.

StephenLPeters · 2020-08-18T22:35:13Z

/azp run

Felix-Dev · 2020-11-02T18:07:27Z

@ranjeshj Merged with master. I also took a look at the interaction tests again I added as part of this PR. The test failing in the test pipeline run - VerifyNavigationViewItemChildrenFlyoutMenuCornerRadius - works fine for me locally, but I do notice the MUXControls test app crashing on me after successfully running that test. The crash appears to happen when the test app process tries to invoke the app's back button while the children flyout menu opened as part of this test is still open. I am now closing the opened flyout in the test and did not not notice any more app crashes (EventViewer stays silent). This hopefully fixes the issue.

ranjeshj · 2020-11-02T18:09:52Z

/azp run

azure-pipelines · 2020-11-02T18:10:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Felix-Dev · 2020-11-02T23:12:32Z

@ranjeshj Looks like the failing test issue has been fixed now. Unfortunately, when merging with master earlier today, I forgot to rename the internal VisualTreeUtils.FindElementOfTypeInParentTree() function. Done now.

ranjeshj · 2020-11-03T15:41:41Z

/azp run

azure-pipelines · 2020-11-03T15:41:57Z

Azure Pipelines successfully started running 1 pipeline(s).

…flyout menu (microsoft/microsoft-ui-xaml#3082)

* Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <28935693+ranjeshj@users.noreply.github.com> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com>

…e 2.5 (#3887) * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * merge master into feature branch (#3556) * Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> * update controls to use design token colors, update styles (#3728) * merge master into feature branch (#3734) * Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <28935693+ranjeshj@users.noreply.github.com> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * add missing PipsPager generatd file (#3755) * Allow microsoft-ui-xaml to support multiple sets of styles (#3690) * update customtask * update project to use the customtool and support UseVisualStyle * support new flag in api * missing one file change for custombuild task * update to new api and address some comments * fix the -> * script to move master xaml to v2.5 and add them to proj * manually correct the missing items * vcxproj back to UTF8 * standard the name and replace previous with 2dot5 * batch remove last line for project * remove pips and address commentss * trim last line * remove newline at the end of file * fix ##[error]dev\dll\XamlControlsResources.cpp(249,0): Error C26449: gsl::span or std::string_view created from a temporary will be invalid when the temporary is invalidated (gsl.view). * remove return type in lambda * remove Expander_v2.5.xaml, move merge.bat to tools and fix the test failure * fix test * Fix RadioButtons colouring bug (#3756) * fix radioButtons colouring bug * changes from comments * Slider Visual Update (#3768) * visual update * re-add missing key * add innerthumb size animation * add colour transitions * changes from comments * colour transitions fix * prepare for merge * Update pfx and cer used for test signing (#3882) * update pfx * update CalendarView.xml master * update default setting and codegen update avoid crash on expander, reveal, NavView and progressbar * resolve merge conflict * enable test * Fix the Latest still using 2.5 styles Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: Karen Lai <7976322+karenbtlai@users.noreply.github.com>

* Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <28935693+ranjeshj@users.noreply.github.com> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com>

Felix-Dev added 3 commits August 8, 2020 16:46

Fix corner radius for the overflow menu and the children flyout menu.

48ef691

Add two interaction tests.

44b5450

Small comment improvements.

11ccea7

msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Aug 8, 2020

Felix-Dev commented Aug 8, 2020

View reviewed changes

test/MUXControlsTestApp/Utilities/VisualTreeUtils.cs Outdated Show resolved Hide resolved

Felix-Dev commented Aug 8, 2020

View reviewed changes

dev/NavigationView/NavigationView_InteractionTests/CommonTests.cs Outdated Show resolved Hide resolved

Small comment improvement.

b9d5ae1

StephenLPeters reviewed Aug 10, 2020

View reviewed changes

dev/NavigationView/NavigationView.xaml Show resolved Hide resolved

StephenLPeters reviewed Aug 10, 2020

View reviewed changes

dev/NavigationView/NavigationView.xaml Show resolved Hide resolved

StephenLPeters reviewed Aug 10, 2020

View reviewed changes

StephenLPeters added area-NavigationView NavView control team-Controls Issue for the Controls team labels Aug 10, 2020

StephenLPeters requested a review from YuliKl August 10, 2020 23:11

StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Aug 10, 2020

YuliKl approved these changes Aug 10, 2020

View reviewed changes

Move top NavigationView specific overflow button tests from CommonTes…

e81d4a0

…ts to TopModeTests.

Merge branch 'master' into user/Felix-Dev/navview-flyouts-cornerradius

e931176

Merge branch 'master' into user/Felix-Dev/navview-flyouts-cornerradius

5ed3d60

Now close opened flyout in API test before finishing.

ed7c947

Rename FindElementOfTypeInParentTree -> FindVisualParentByType

3a1b374

ranjeshj merged commit a9dd3ba into microsoft:master Nov 7, 2020

Felix-Dev deleted the user/Felix-Dev/navview-flyouts-cornerradius branch November 7, 2020 08:33

Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 8, 2020

NavView: Fix CornerRadius for overflow menu and NavViewItem children …

8198231

…flyout menu (microsoft/microsoft-ui-xaml#3082)

dependabot bot mentioned this pull request Jan 17, 2021

Bump ModernWpfUI from 0.9.2 to 0.9.3 HMBSbige/BilibiliLiveRecordDownLoader#32

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu #3082

NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu #3082

Felix-Dev commented Aug 8, 2020 •

edited

Loading

StephenLPeters Aug 10, 2020

Felix-Dev Aug 10, 2020 •

edited

Loading

StephenLPeters commented Aug 10, 2020

azure-pipelines bot commented Aug 10, 2020

Felix-Dev commented Aug 11, 2020 •

edited

Loading

marcelwgn commented Aug 11, 2020

Felix-Dev commented Aug 11, 2020 •

edited

Loading

StephenLPeters commented Aug 11, 2020

StephenLPeters commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

Felix-Dev commented Aug 11, 2020

StephenLPeters commented Aug 18, 2020

Felix-Dev commented Aug 18, 2020

StephenLPeters commented Aug 18, 2020

Felix-Dev commented Nov 2, 2020 •

edited

Loading

ranjeshj commented Nov 2, 2020

azure-pipelines bot commented Nov 2, 2020

Felix-Dev commented Nov 2, 2020

ranjeshj commented Nov 3, 2020

azure-pipelines bot commented Nov 3, 2020

NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu #3082

NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu #3082

Conversation

Felix-Dev commented Aug 8, 2020 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots:

StephenLPeters Aug 10, 2020

Choose a reason for hiding this comment

Felix-Dev Aug 10, 2020 • edited Loading

Choose a reason for hiding this comment

StephenLPeters commented Aug 10, 2020

azure-pipelines bot commented Aug 10, 2020

Felix-Dev commented Aug 11, 2020 • edited Loading

marcelwgn commented Aug 11, 2020

Felix-Dev commented Aug 11, 2020 • edited Loading

StephenLPeters commented Aug 11, 2020

StephenLPeters commented Aug 11, 2020

azure-pipelines bot commented Aug 11, 2020

Felix-Dev commented Aug 11, 2020

StephenLPeters commented Aug 18, 2020

Felix-Dev commented Aug 18, 2020

StephenLPeters commented Aug 18, 2020

Felix-Dev commented Nov 2, 2020 • edited Loading

ranjeshj commented Nov 2, 2020

azure-pipelines bot commented Nov 2, 2020

Felix-Dev commented Nov 2, 2020

ranjeshj commented Nov 3, 2020

azure-pipelines bot commented Nov 3, 2020

Felix-Dev commented Aug 8, 2020 •

edited

Loading

Felix-Dev Aug 10, 2020 •

edited

Loading

Felix-Dev commented Aug 11, 2020 •

edited

Loading

Felix-Dev commented Aug 11, 2020 •

edited

Loading

Felix-Dev commented Nov 2, 2020 •

edited

Loading