Update CommandBarFlyout closing animation to include button moving #3594

marcelwgn · 2020-11-11T18:30:52Z

Description

The issue was that the PrimaryIcons container shrunk immediately when closing the CommandBar resulting in an animation missmatch. By setting the MinWidth instead of the Width, we are no longer experiencing that missmatch.

Cool side effect: When collapsing the flyout (clicking more button when expanded), the button also animates now instead of jumping.

I needed to adjust the background as the root container sized in a different manner resulting in the background being behind of the animation of the button.

Motivation and Context

Closes #3515

How Has This Been Tested?

Tested manually.

Screenshots (if appropriate):

StephenLPeters · 2020-11-12T21:05:48Z

dev/CommandBarFlyout/CommandBarFlyout.xaml

                            Height="{TemplateBinding Height}"
-                            Background="{TemplateBinding Background}"


t [](start = 47, length = 1)

Why did the background have to get moved? can it be moved to the ContentRoot grid instead of both its children?

Oh forgot to reply, the reason why we moved the background is that the "outer" container is not lined up with the animation of the button. The width lags behind resulting in the background being visible even if the button already animated to the correct position. Updated it to use the contentroot grid instead.

dev/CommandBarFlyout/CommandBarFlyout.xaml

StephenLPeters · 2020-11-12T21:06:42Z

/azp run

azure-pipelines · 2020-11-12T21:07:08Z

Azure Pipelines successfully started running 1 pipeline(s).

…on-match

ranjeshj · 2020-11-21T13:25:44Z

/azp run

azure-pipelines · 2020-11-21T13:25:55Z

Azure Pipelines successfully started running 1 pipeline(s).

mdtauk · 2020-11-21T13:44:46Z

@chingucoding Can I ask a slightly related question.

The smoothness of the animation for the CommandBarFlyout. Is there any reason that the same kind of animation couldn't be applied to the CalendarDatePicker flyout? Or to any of the Date and Time flyouts?

marcelwgn · 2020-11-21T13:56:41Z

The smoothness of the animation for the CommandBarFlyout. Is there any reason that the same kind of animation couldn't be applied to the CalendarDatePicker flyout? Or to any of the Date and Time flyouts?

Technically speaking, yes it could be used. The problem is though, that CommandBarFlyout uses a lot of template settings to get that animation behave the way it does. I don't know how the flyouts you mentioned work under the hood, but it would probably require a more work from code behind to have the same animation.

mdtauk · 2020-11-21T14:00:05Z

The smoothness of the animation for the CommandBarFlyout. Is there any reason that the same kind of animation couldn't be applied to the CalendarDatePicker flyout? Or to any of the Date and Time flyouts?

Technically speaking, yes it could be used. The problem is though, that CommandBarFlyout uses a lot of template settings to get that animation behave the way it does. I don't know how the flyouts you mentioned work under the hood, but it would probably require a more work from code behind to have the same animation.

Thanks for indulging me. Let's hope that when WinUI 3 source add happens, or when these controls get updates - some of these things can be addressed

marcelwgn · 2020-11-21T14:23:51Z

Thanks for indulging me. Let's hope that when WinUI 3 source add happens, or when these controls get updates - some of these things can be addressed

I am not sure if there is a tracking issue/proposal for that, but maybe it's worth opening one? Of course such changes would also have to be discussed with design, but given that CommandBarFlyout has those animations, there is a point to make to maybe bring that to other controls.

mdtauk · 2020-11-21T14:51:56Z

Thanks for indulging me. Let's hope that when WinUI 3 source add happens, or when these controls get updates - some of these things can be addressed

I am not sure if there is a tracking issue/proposal for that, but maybe it's worth opening one? Of course such changes would also have to be discussed with design, but given that CommandBarFlyout has those animations, there is a point to make to maybe bring that to other controls.

If I were to open one, it couldn't be explored until WinUI 3.0 is done and the code is in the repo.

If proposals for changing any of those controls appear, I will mention improving the transitions for those. As well as density support for flyouts from controls using the Compact Density ResourceDictionaries

marcelwgn · 2020-11-21T14:55:21Z

If I were to open one, it couldn't be explored until WinUI 3.0 is done and the code is in the repo.

Yes this is something that would probably have to wait until WinUI 3.0.

If proposals for changing any of those controls appear, I will mention improving the transitions for those. As well as density support for flyouts from controls using the Compact Density ResourceDictionaries

👍

…icrosoft/microsoft-ui-xaml#3594)

* Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <28935693+ranjeshj@users.noreply.github.com> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com>

…e 2.5 (#3887) * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * merge master into feature branch (#3556) * Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> * update controls to use design token colors, update styles (#3728) * merge master into feature branch (#3734) * Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <28935693+ranjeshj@users.noreply.github.com> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> * add missing PipsPager generatd file (#3755) * Allow microsoft-ui-xaml to support multiple sets of styles (#3690) * update customtask * update project to use the customtool and support UseVisualStyle * support new flag in api * missing one file change for custombuild task * update to new api and address some comments * fix the -> * script to move master xaml to v2.5 and add them to proj * manually correct the missing items * vcxproj back to UTF8 * standard the name and replace previous with 2dot5 * batch remove last line for project * remove pips and address commentss * trim last line * remove newline at the end of file * fix ##[error]dev\dll\XamlControlsResources.cpp(249,0): Error C26449: gsl::span or std::string_view created from a temporary will be invalid when the temporary is invalidated (gsl.view). * remove return type in lambda * remove Expander_v2.5.xaml, move merge.bat to tools and fix the test failure * fix test * Fix RadioButtons colouring bug (#3756) * fix radioButtons colouring bug * changes from comments * Slider Visual Update (#3768) * visual update * re-add missing key * add innerthumb size animation * add colour transitions * changes from comments * colour transitions fix * prepare for merge * Update pfx and cer used for test signing (#3882) * update pfx * update CalendarView.xml master * update default setting and codegen update avoid crash on expander, reveal, NavView and progressbar * resolve merge conflict * enable test * Fix the Latest still using 2.5 styles Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com> Co-authored-by: Karen Lai <7976322+karenbtlai@users.noreply.github.com>

* Move build to windevbuildagents (#3511) * Remove infobar from innerloop when it isn't explicitly included. (#3512) * Remove infobar from innerloop when it isn't explicitly included. * Update InnerLoopAreas.props Remove feature area from InnerLoopAreas * add condition * revert innerloop solution file * revert innerloop solution file * Update script to add API test projects and add empty dependency list in FeatureArea.props file (#3474) * Update new control script to add API test project * Update script to add dependencies, clean up script * * Rename FindElementOfTypeInSubtree -> FindVisualChildByType (#3438) * FindVisualChildByName() now an extension method * internal code cleanup * IsSelectionRequried -> IsSelectionRequired (#3404) * IsSelectionRequried -> IsSelectionRequired * TreeViewListAutomationPeer::IsSelectionRequired() always returns false. * Update the test infra to account for the test app having a different name when built from the inner loop solution. (#3359) * Feature/expander (#3492) Adding expander control (#3492). * Initial check-in for colors/brushes, preliminary button brush updates, and adding visual states test page (#3514) * add visual states test page * add visual states test page * Add new colors, update Button* brushes * Tweaked CSV, added accent button * Fix bad merge * Added elevation border brushes * Temporarily disable failing tests so other work can be unblocked. * NavView: Fix CornerRadius for overflow menu and NavViewItem children flyout menu (#3082) * Fix corner radius for the overflow menu and the children flyout menu. * Add two interaction tests. * Small comment improvements. * Small comment improvement. * Move top NavigationView specific overflow button tests from CommonTests to TopModeTests. * Now close opened flyout in API test before finishing. * Rename FindElementOfTypeInParentTree -> FindVisualParentByType * Add missing resource files to LocConfig (#3567) * Cache IsFullScreenMode and invalidate the value only when SizeChanged is raised (#3569) * Fix issue with ProgressRing not acting correctly when moving backwards (#3565) * Add workaround for awkward progress ring behavior. * Update progresring backwards behavior * move pager resources under strings/en-us folder (#3593) * make footer menu items public (#3519) * update progress ring idl (#3599) * TabView: Fix newly-added items not respecting TabWidthMode [compact] when using an ItemsSource collection (#3118) * Fix the following issues when populating the TabView via its ItemsSource API: * crash when clearing the ItemsSource * TabWidthMode [compact] being ignored in XAML Markup and for newly-added items * small comment improvement * Added two API tests and modified existing test. * Unrelated code which was commented out is run again. * Add API test. * Simplified API test. * Merge API tests. * Add API contract checks for corner radius. * Ensure that listview selected index is not outside of the item range. * Update TabView.cpp Co-authored-by: Ranjesh <28935693+ranjeshj@users.noreply.github.com> * Switch to using ThemeResource for icon in InfoBar (#3603) * Allow winui to detect if it's in CBS package (#3520) * build cbs * Revert "build cbs" This reverts commit 24b6812. * cbs: * Update dev/dll/SharedHelpers.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Update dev/dll/XamlControlsResources.cpp Co-authored-by: Jevan Saks <jevansa@microsoft.com> * remove check for old platform and add assert * make pipeline build cbs resources.pri and manifest * Update dev/dll/XamlControlsResources.cpp * Update dev/dll/XamlControlsResources.cpp * fail fast * Update dev/dll/XamlControlsResources.cpp * fix package name when generate CBSManifest Co-authored-by: Jevan Saks <jevansa@microsoft.com> * Doc/roadmap updates (#3618) * Updating ordering * Updating feature roadmap * More updates to feature roadmap, roadmap graphic * Update bug_report.md (#3622) * Fix readme to mention Preview 3 instead of P2 (#3621) * Update NavigationView pane scrolling behavior (#3602) * Add initial layout updating, add test page * Add first interaction tests * Fix behavior, add scrolling behavior * CR feedback * Add hacky workaround for weird sizing behavior * Update layout, add separator * Fix updating behavior * Remove hacky workaround, fix test * Add fault tolerance to tests * Update verification files * Change Preview 2 to Preview 3 (#3626) * Update preview_upgrade_instructions.md (#3636) * TeachingTip: Fix background for light-dismissable tip (#3440) * Add missing visual state setters. * Extend API test. * update loc strings (#3650) * File Pipeline build break: Update Nuget from 5.2 to 5.8 (#3664) * Fixing an issue where we needed a FileWrites to avoid file deletion. (#3661) * Remove explicit sizes of InfoBar (#3653) * Remove explicit sizes of InfoBar * Set minheight for centering * Switch to lightweight styling resources * Update CommandBarFlyout closing animation to include button moving (#3594) * Update more-button animation behavior * Fix background issue * CR feedback * update intellisense file (#3651) * Update AcrylicBrushes and add new AcrylicBrushes (#3498) * Add new brushes, update CommandbarFlyout and NavigationView to use new brushes * Update brushes * Update brush references * Update project file * Update navigationview resources * Hacky workaround XAML compiler bug * Add check * Add comment * Fix typo * Add ImageIcon (#3629) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Fix Innerloop Solution (#3697) * Add ImageIcon * Respond to feedback and use an svg image with an MIT license. * Fix broken test * Platform check the IsLoaded check which was introduced in RS5 * Add preprocessor declaration around imageIconSource code in MakeIconElementFrom * Update InfoBarPanel API names (#3704) * Update API names * Remove grid.columns * Adding PipsPager (#3592) * PipsControl initial structure * PipsControl update file structure * Add boilerplate code * Add styles and update logic * Remove Grid inside the PipsControl * some layout fixes * Update common styles * Fix nav buttons visibility logic * Update themeresources and fix infinite scrolling * Clean up the code * Remove InneLoopAreasProps from PR * Add automation * Update resources file * Fix button visibility for automation * Fix navigaiton buttons disappearing bug * Update .idl file and add style as properties * Add handlers for button visibility changes * Add style handlers and update accessibility * Add basic test with flipview * Fix update of max number of pages * Fix maxdisplayedpages onchange handler and address small PR issues * remove commented code * Update Naming * Fix naming and fix pointer hover event * Update Tests and leave some comments * Update naming and tests * Fix sv change size and override virtual methods * Address PR comments * Address PR issues * Fix button not showing up on initial launch * Clean up the code * Update API tests * Partially Update Tests * Fix spacing * Update Strings * Attempt to fix tests * Attempt to fix tests * Fall back to manual scroll if fresh API is not available * Move API check to SharedHelpers * Fix naming Co-authored-by: Ranjesh Jaganathan <28935693+ranjeshj@users.noreply.github.com> * fix tests * ImageIcon test fix Co-authored-by: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Co-authored-by: Stephen L Peters <stpete@microsoft.com> Co-authored-by: Marcel Wagner <marcel.alex.wagner@outlook.com> Co-authored-by: Felix-Dev <FelixDev91@gmail.com> Co-authored-by: Tony Xia <xia_tony@hotmail.com> Co-authored-by: EJ <lalotahoma@icloud.com> Co-authored-by: T Paine <30241445+teaP@users.noreply.github.com> Co-authored-by: Jevan Saks <jevansa@microsoft.com> Co-authored-by: Canhua Li <licanhua@live.com> Co-authored-by: Ana Wishnoff <anawish@microsoft.com> Co-authored-by: Morten Nielsen <1378165+dotMorten@users.noreply.github.com> Co-authored-by: Thomas Claudius Huber <thomas@thomasclaudiushuber.com> Co-authored-by: Luke Longley <18177025+llongley@users.noreply.github.com> Co-authored-by: Vsevolod <sevkorobot@gmail.com>

marcelwgn added 2 commits November 11, 2020 18:02

Update more-button animation behavior

ee7a669

Fix background issue

d410a4c

ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 11, 2020

StephenLPeters reviewed Nov 12, 2020

View reviewed changes

dev/CommandBarFlyout/CommandBarFlyout.xaml Show resolved Hide resolved

CR feedback

d571a5d

StephenLPeters added area-Commanding AppBar, UICommand, MVVM, etc team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Nov 14, 2020

Merge branch 'master' into user/chingucoding/commandbarflyout-animati…

b8caf0c

…on-match

ranjeshj approved these changes Nov 22, 2020

View reviewed changes

ranjeshj merged commit 682dc5e into microsoft:master Nov 22, 2020

Kinnara added a commit to Kinnara/ModernWpf that referenced this pull request Nov 29, 2020

Update CommandBarFlyout closing animation to include button moving (m…

f16f269

…icrosoft/microsoft-ui-xaml#3594)

ranjeshj mentioned this pull request Dec 2, 2020

RichEditBox TextCommandBarFlyout UI glitches #2735

Closed

dependabot bot mentioned this pull request Jan 17, 2021

Bump ModernWpfUI from 0.9.2 to 0.9.3 HMBSbige/BilibiliLiveRecordDownLoader#32

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CommandBarFlyout closing animation to include button moving #3594

Update CommandBarFlyout closing animation to include button moving #3594

marcelwgn commented Nov 11, 2020

StephenLPeters Nov 12, 2020

marcelwgn Nov 21, 2020

StephenLPeters commented Nov 12, 2020

azure-pipelines bot commented Nov 12, 2020

ranjeshj commented Nov 21, 2020

azure-pipelines bot commented Nov 21, 2020

mdtauk commented Nov 21, 2020

marcelwgn commented Nov 21, 2020

mdtauk commented Nov 21, 2020 •

edited

Loading

marcelwgn commented Nov 21, 2020

mdtauk commented Nov 21, 2020

marcelwgn commented Nov 21, 2020

		Height="{TemplateBinding Height}"
		Background="{TemplateBinding Background}"

Update CommandBarFlyout closing animation to include button moving #3594

Update CommandBarFlyout closing animation to include button moving #3594

Conversation

marcelwgn commented Nov 11, 2020

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

StephenLPeters Nov 12, 2020

Choose a reason for hiding this comment

marcelwgn Nov 21, 2020

Choose a reason for hiding this comment

StephenLPeters commented Nov 12, 2020

azure-pipelines bot commented Nov 12, 2020

ranjeshj commented Nov 21, 2020

azure-pipelines bot commented Nov 21, 2020

mdtauk commented Nov 21, 2020

marcelwgn commented Nov 21, 2020

mdtauk commented Nov 21, 2020 • edited Loading

marcelwgn commented Nov 21, 2020

mdtauk commented Nov 21, 2020

marcelwgn commented Nov 21, 2020

mdtauk commented Nov 21, 2020 •

edited

Loading