Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Commit

Permalink
Add @types/webpack dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
@kube
kube committed Nov 15, 2018
1 parent d558cab commit d7b9a17
Show file tree
Hide file tree
Showing 2 changed files with 753 additions and 716 deletions.
Loading

2 comments on commit d7b9a17

@trey-miller
Copy link

@trey-miller trey-miller commented on d7b9a17 Jan 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke my build. @types/webpack has a dependency of @types/node, which has incompatibilities with browser objects, most notably setTimeout in node environments returns a NodeJS.Timeout type instead of a number.

@simerlec
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also broke my build - or at least it broke the webpack-dev-server in --watch mode. Using releases which include this new dependency in an Angular project creates this issue.

Please sign in to comment.