Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose capability to set HTML "required" property on textarea #4021

Closed
2 tasks done
raharri opened this issue Jun 12, 2023 · 5 comments · Fixed by microsoft/vscode#187318
Closed
2 tasks done
Assignees
Labels
editor-core feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@raharri
Copy link

raharri commented Jun 12, 2023

Context

  • This issue is not a bug report. (please use a different template for reporting a bug)
  • This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description

For some use cases of the monaco editor, the editor's input area is a required property (for example, if the user must input a SQL query to fetch results). Currently the monaco editor doesn't expose a way to set the required or aria-required HTML property on the textarea element, which is an accessibility requirement for these use cases.

(This came up in an accessibility pass and @isidorn asked me to file a feature request here.)

Monaco Editor Playground Link

No response

Monaco Editor Playground Code

No response

@raharri raharri added the feature-request Request for new features or functionality label Jun 12, 2023
@fsteffi
Copy link

fsteffi commented Jun 13, 2023

GitHub Tags:#A11yTCS;#A11y_VSCode;#CAITestPass_May2020; #DesktopApp;#Win11;#MAS3.3.2;#Benchmark;#FTP;#A11yMAS;#A11ySev2;#AINotInScope;#Keyboard;#Visual Studio Code;

@hediet hediet self-assigned this Jun 13, 2023
@hediet hediet added this to the June 2023 milestone Jun 13, 2023
@hediet hediet modified the milestones: June 2023, July 2023 Jun 28, 2023
@hediet
Copy link
Member

hediet commented Jul 7, 2023

You can now set ariaRequired: true in the editor options. FYI @isidorn

Monaco editor example (use latest nightly)

@isidorn
Copy link

isidorn commented Jul 10, 2023

@hediet awesome! Should we go ahead and close this then?

@hediet
Copy link
Member

hediet commented Jul 10, 2023

It will be closed automatically once the implementing PR gets merged. Somehow the build timed out Friday.

hediet added a commit to microsoft/vscode that referenced this issue Jul 10, 2023
@hediet hediet added the verification-needed Verification of issue is requested label Jul 21, 2023
@Tyriar
Copy link
Member

Tyriar commented Jul 25, 2023

No error on latest 0.41:

Screenshot 2023-07-25 at 12 16 17 pm

@Tyriar Tyriar added the verified Verification succeeded label Jul 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants