Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(monosize): add --fixture argument to measure command to target specific fixture files #75

Merged
merged 4 commits into from
Jul 24, 2024
Merged

feat(monosize): add --fixture argument to measure command to target specific fixture files #75

merged 4 commits into from
Jul 24, 2024

Conversation

benkeen
Copy link
Contributor

@benkeen benkeen commented Jul 13, 2024

This adds an optional --fixtures argument to allow the monosize measure command to target specific fixtures by filename or pattern.

README updated with examples.

@benkeen benkeen requested review from layershifter and a team as code owners July 13, 2024 02:35
@benkeen benkeen mentioned this pull request Jul 13, 2024
Closed
@tudorpopams tudorpopams requested a review from Hotell July 16, 2024 12:04
Hotell
Hotell requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty !

I added couple of comments, most of them need action from your side.

packages/monosize/src/commands/measure.test.mts Outdated Show resolved Hide resolved
packages/monosize/src/commands/measure.test.mts Outdated Show resolved Hide resolved
change/monosize-190af040-06c8-4534-88ab-f97941ef976d.json Outdated Show resolved Hide resolved
packages/monosize/src/commands/measure.mts Outdated Show resolved Hide resolved
packages/monosize/src/commands/measure.mts Outdated Show resolved Hide resolved
packages/monosize/src/commands/measure.mts Outdated Show resolved Hide resolved
packages/monosize/src/commands/measure.mts Outdated Show resolved Hide resolved
packages/monosize/src/commands/measure.test.mts Outdated Show resolved Hide resolved
@Hotell Hotell changed the title Add arg to measure command to target specific fixture files feat(monosize): add --fixture argument to measure command to target specific fixture files Jul 17, 2024
@benkeen benkeen force-pushed the measure-command-fixtures-arg branch from 72c0edd to b51cfeb Compare July 18, 2024 04:48
@benkeen
Copy link
Contributor Author

benkeen commented Jul 18, 2024

Thanks, @Hotell! I've incorporated those changes.

@Hotell
Copy link
Contributor

Hotell commented Jul 18, 2024

Thanks, @Hotell! I've incorporated those changes.

two more things and we should be ready to merge. ty!

@benkeen
Copy link
Contributor Author

benkeen commented Jul 22, 2024

Thanks @Hotell! Updated.

@benkeen benkeen force-pushed the measure-command-fixtures-arg branch from cc810ff to 4053bc0 Compare July 22, 2024 04:11
@Hotell Hotell self-requested a review July 24, 2024 11:33
Hotell
Hotell approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hotell Hotell self-requested a review July 24, 2024 11:48
@Hotell Hotell force-pushed the measure-command-fixtures-arg branch from 4053bc0 to 7c35b4e Compare July 24, 2024 11:52
@Hotell Hotell merged commit ce8d61e into microsoft:main Jul 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benkeen @Hotell