Reenable BlockMap negative tests #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
He had to disable some BlockMap tests because the packages were from Win8. This change recreates the tests with new Win10 faulty packages.
Expected behavior:
G:\msix-packaging.vs>bin\makemsix.exe unpack -d try -p File_missing_from_blockmap.msix -ss
Microsoft (R) makemsix version 1.6.57
Copyright (C) 2017 Microsoft. All rights reserved.
Error: 8bad0051
LOG:
Payload file not described in AppxBlockMap.xml
Call failed in G:\msix-packaging\src\msix\AppxPackageObject.cpp on line 364
Call failed in G:\msix-packaging\src\msix\msix.cpp on line 66
G:\msix-packaging.vs>bin\makemsix.exe unpack -d try -p Extra_file_in_blockmap.msix -ss
Microsoft (R) makemsix version 1.6.57
Copyright (C) 2017 Microsoft. All rights reserved.
Error: 80070002
LOG:
File described in blockmap not contained in OPC container
Call failed in G:\msix-packaging\src\msix\AppxPackageObject.cpp on line 354
Call failed in G:\msix-packaging\src\msix\msix.cpp on line 66
G:\msix-packaging.vs>bin\makemsix.exe unpack -d try -p Size_wrong_uncompressed.msix -ss
Microsoft (R) makemsix version 1.6.57
Copyright (C) 2017 Microsoft. All rights reserved.
Error: 8bad0051
LOG:
Uncompressed size of the file in the block map and the OPC container don't match
Call failed in G:\msix-packaging\src\msix\AppxPackageObject.cpp on line 414
Call failed in G:\msix-packaging\src\msix\msix.cpp on line 66
G:\msix-packaging.vs>bin\makemsix.exe unpack -d ouput -p Invalid_Bad_Block.msix -ss
Microsoft (R) makemsix version 1.6.57
Copyright (C) 2017 Microsoft. All rights reserved.
Error: 8bad0051
LOG:
Compressed size of the file in the block map and the OPC container don't match
Call failed in G:\msix-packaging\src\msix\AppxPackageObject.cpp on line 406
Call failed in G:\msix-packaging\src\msix\msix.cpp on line 66
TODO: recreate bundles