Extra Protection Around Stream Send Queue #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
Area: Core
thhous-msft
approved these changes
Mar 5, 2022
nibanks
added a commit
that referenced
this pull request
Mar 7, 2022
nibanks
added a commit
that referenced
this pull request
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've seen some crashes internally in the latest builds where somehow a stream seems to be dequeued twice. I haven't yet pinned down the extact repro steps of the scenario that triggers this, but it's simple enough to check and protect from this happening.
Testing
Verified existing tests pass. Ideally, I'd like to write a new test case to repro the original issue, but I haven't figured out the steps to do so yet.