-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor epoll Send Path #3274
Refactor epoll Send Path #3274
Conversation
Datapath->SendIoVecCount = 1; | ||
} else { | ||
const uint32_t SendDataSize = | ||
sizeof(CXPLAT_SEND_DATA) + (CXPLAT_MAX_BATCH_SEND - 1) * sizeof(struct iovec); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this should be FIELD_OFFSET(CXPLAT_SEND_DATA, Iovs) + CXPLAT_MAX_BATCH_SEND * sizeof(struct iovec)
since Iovs[1];
isn't required to be aligned to the end of the struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the code I have might just allocate a bit more because of possible padding? I'm fine with that.
Description
Lots of refactoring for the epoll send path.
Testing
Existing CI
Documentation
N/A