Call UpdateQeo from Connection #3607

ami-GS · 2023-05-03T23:22:37Z

Description

Call UpdateQeo from Connection
Leveraging #3600

QUIC_SETTINGS to have EncryptionOffloadEnabled flag
QUIC_CONNECTION_STATE to have state to indicate whether currently offloading
Offloading is actually enabled at the end of ConnStart

Testing

Documentation

src/inc/quic_datapath.h

src/inc/msquic.h

… on Offloading

nibanks

Looking good so far. Still a few things left to do.

src/core/connection.c

src/core/connection.h

src/core/settings.c

src/inc/msquic.h

src/inc/quic_datapath.h

src/core/settings.h

src/core/connection.h

src/core/connection.c

src/inc/msquic.h

src/core/quicdef.h

src/core/settings.c

src/core/connection.c

src/core/settings.c

+    if (!Settings->IsSet.EncryptionOffloadAllowed) {
+        Value = QUIC_DEFAULT_ENCRYPTION_OFFLOAD_ALLOWED;
+        ValueLen = sizeof(Value);
+        CxPlatStorageReadValue(


src/core/crypto.c

* Use qeo flag in secnetperf * extern variable * wrap QUIC_SETTINGS related lines as preview feature * remove preview feature ifdef

src/core/connection.c

…sl/schannel

src/core/connection.c

src/inc/quic_datapath.h

src/inc/quic_tls.h

src/core/connection.c

src/core/crypto.c

src/core/path.c

src/core/crypto.c

src/core/connection.c

src/core/crypto.c

src/core/settings.c

…LS_OFFLOAD_SECRETS

src/core/crypto.c

src/core/path.h

src/inc/quic_crypt.h

src/core/crypto.h

Call QeoUpdate from Connection

ec017fe

ami-GS requested a review from a team as a code owner May 3, 2023 23:22

csujedihy reviewed May 3, 2023

View reviewed changes

src/inc/quic_datapath.h Outdated Show resolved Hide resolved

nibanks reviewed May 3, 2023

View reviewed changes

src/inc/msquic.h Outdated Show resolved Hide resolved

ami-GS added 2 commits May 3, 2023 16:48

fix comment

e73a1e1

Stats for user to know offloading state. Change Encrypted state based…

1c1cce5

… on Offloading

nibanks reviewed May 4, 2023

View reviewed changes

src/inc/msquic.h Outdated Show resolved Hide resolved

nibanks reviewed May 4, 2023

View reviewed changes

src/inc/msquic.h Outdated Show resolved Hide resolved

move status to Path, wrap QUIC_SETTINGS change in preview feature

1602ab5

nibanks reviewed May 4, 2023

View reviewed changes

src/core/quicdef.h Outdated Show resolved Hide resolved

nibanks reviewed May 4, 2023

View reviewed changes

src/core/settings.c Outdated Show resolved Hide resolved

ami-GS added 2 commits May 4, 2023 13:12

remove preview feature ifdef from core

5f1113f

set default values (not sure if these are correct)

5a0c0c3

github-advanced-security bot found potential problems May 5, 2023

View reviewed changes

move qeo update after handshake complete

8a0c0ab

github-advanced-security bot found potential problems May 5, 2023

View reviewed changes

src/core/crypto.c Fixed Show fixed Hide fixed

src/core/crypto.c Fixed Show fixed Hide fixed

ami-GS added 2 commits May 5, 2023 09:59

Use qeo flag in secnetperf (#3609)

f4697f2

* Use qeo flag in secnetperf * extern variable * wrap QUIC_SETTINGS related lines as preview feature * remove preview feature ifdef

use appropriate CIDs and keys

5d4549c

github-advanced-security bot found potential problems May 6, 2023

View reviewed changes

src/core/connection.c Fixed Show fixed Hide fixed

ami-GS added 4 commits May 5, 2023 23:06

hacky block for windows

863b9d0

clog update

bd3e23d

remove hacky implementation, generate dotnet

b1a6ecf

cleanup struct initialization for ConnUninitialize

ac542f1

github-advanced-security bot found potential problems May 8, 2023

View reviewed changes

src/core/connection.c Fixed Show fixed Hide fixed

ami-GS added 3 commits May 8, 2023 11:54

remove ifdef for windows

c66ff3d

Fix Linux build failure by SAL definition

b4b2df3

Remove Offload specific functions. Unify functionality for both opens…

c07633b

…sl/schannel

github-advanced-security bot found potential problems May 9, 2023

View reviewed changes

src/core/connection.c Fixed Show fixed Hide fixed