-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UDPv6 checksum #3693
Fix UDPv6 checksum #3693
Conversation
Why? |
UDPv4 checksum is optional. UDP checksum is required only with IPv6. |
I assume you haven't validated this in a real environment (i.e. Azure VM)? I will sign off, and leave it up to you if you're sure enough to merge without further validation. |
Some middleboxes might not like zero UDPv4 checksum. Though, I am pretty sure it works fine over azure with linux and windows. I am gonna revert this change to be safe. We could add a knob to disable UDPv4 checksum in the future even for regular QUIC. We have UDP_NOCHECKSUM for windows UDP sockets to disable it, and UDPv4 checksum is default on. |
Does this handle the UDPv6 case that we recently fixed in XDP? That is, the UDPv6 checksum must not be zero? |
Yes it does. I was looking at the wrong commit diff. |
Description
UDPv6 requires checksum to be non-zero.
Testing
CI