-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reliable Reset Stream Support - Phase 1 - Feature Negotiation #3778
Merged
nibanks
merged 47 commits into
main
from
jackhe/support-quic-reliable-stream-reset-3775
Aug 11, 2023
Merged
Reliable Reset Stream Support - Phase 1 - Feature Negotiation #3778
nibanks
merged 47 commits into
main
from
jackhe/support-quic-reliable-stream-reset-3775
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Jul 26, 2023
nibanks
reviewed
Jul 26, 2023
ami-GS
reviewed
Jul 26, 2023
ami-GS
reviewed
Jul 26, 2023
ami-GS
reviewed
Jul 26, 2023
nibanks
reviewed
Jul 26, 2023
ami-GS
reviewed
Jul 26, 2023
nibanks
reviewed
Jul 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #3778 +/- ##
==========================================
- Coverage 77.58% 77.05% -0.53%
==========================================
Files 56 56
Lines 15558 15694 +136
==========================================
+ Hits 12070 12093 +23
- Misses 3488 3601 +113
|
nibanks
reviewed
Jul 28, 2023
nibanks
reviewed
Jul 28, 2023
nibanks
reviewed
Jul 28, 2023
nibanks
reviewed
Jul 28, 2023
nibanks
reviewed
Aug 2, 2023
nibanks
reviewed
Aug 2, 2023
nibanks
reviewed
Aug 2, 2023
nibanks
reviewed
Aug 2, 2023
Co-authored-by: Nick Banks <nibanks@microsoft.com>
ProjectsByJackHe
changed the title
Support new experimental CLOSE_STREAM packet frame. Initialization PR.
Support new experimental CLOSE_STREAM packet frame. Initialization PR to add feature negotiation.
Aug 2, 2023
Co-authored-by: Nick Banks <nibanks@microsoft.com>
nibanks
changed the title
Support new experimental CLOSE_STREAM packet frame. Initialization PR to add feature negotiation.
Reliable Reset Stream Support - Phase 1 - Feature Negotiation
Aug 10, 2023
nibanks
added
Area: Protocol Updates
Changes for new protocol changes
Area: API
Area: Core
Related to the shared, core protocol logic
labels
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
Co-authored-by: Nick Banks <nibanks@microsoft.com>
nibanks
reviewed
Aug 10, 2023
nibanks
reviewed
Aug 10, 2023
Co-authored-by: Nick Banks <nibanks@microsoft.com>
Co-authored-by: Nick Banks <nibanks@microsoft.com>
nibanks
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: API
Area: Core
Related to the shared, core protocol logic
Area: Protocol Updates
Changes for new protocol changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a start to trying to solve issue#3775.
It's implementation is based off https://datatracker.ietf.org/doc/draft-ietf-quic-reliable-stream-reset/
As you can imagine, the changes will be HUUUUUUUUUUGE, so I wanted to split it into multiple PRs, to ease the review process.
In terms of scope for this PR,
we want to build all the necessary logic for proper feature negotiation between client and server.
This includes adding a new Transport parameter, a new settings parameter (internal and external), and logic to handle
negotiation of the settings. Additionally, a new Connection event is necessary to communicate to the app the outcome of a feature negotiation, so the app knows and can respond accordingly.
Testing
New unit tests are added to validate the behavior of the various components. Including new Frame tests, Settings tests, and Transport parameter tests.
End 2 end testing is also in scope for this PR, to validate the behavior of the TLS negotiation.
Documentation
Not in this PR, but for future, there should be docs outlining how to use this new experimental feature.