Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a name to unnamed struct QUIC_HANDLE #3786

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

Koishilll
Copy link
Contributor

Description

Add a name to unnamed struct QUIC_HANDLE to improve compatibility with C++. #3785

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

Is there any documentation impact for this change?

@Koishilll Koishilll requested a review from a team as a code owner July 31, 2023 19:26
src/core/connection.h Outdated Show resolved Hide resolved
@Koishilll
Copy link
Contributor Author

@microsoft-github-policy-service agree

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3786 (ff70f52) into main (d654850) will decrease coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3786      +/-   ##
==========================================
- Coverage   77.51%   77.13%   -0.38%     
==========================================
  Files          56       56              
  Lines       15558    15558              
==========================================
- Hits        12060    12001      -59     
- Misses       3498     3557      +59     
Files Changed Coverage Δ
src/core/configuration.h 100.00% <ø> (ø)
src/core/stream.h 92.30% <ø> (ø)

... and 12 files with indirect coverage changes

@nibanks nibanks added Area: Build external Proposed by non-MSFT labels Aug 1, 2023
@nibanks nibanks merged commit 64e403a into microsoft:main Aug 1, 2023
419 of 423 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants