datapath_epoll: adjust CXPLAT_MAX_IO_BATCH_SIZE arithmetic #3919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should account for MIN MTU, not MAX. Updates microsoft#3917 Signed-off-by: Jordan Whited <jordan@tailscale.com>
nibanks
approved these changes
Oct 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #3919 +/- ##
==========================================
- Coverage 86.97% 86.58% -0.40%
==========================================
Files 56 56
Lines 16889 16889
==========================================
- Hits 14690 14624 -66
- Misses 2199 2265 +66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should account for MIN MTU, not MAX.
Updates #3917
Description
This PR increases the value for the constant controlling the max number of datagrams per coalesced group on Linux. Previously this value was lower than what the max batch size needed to reach in cases where MTU < 1500.
Testing
I'm not familiar with related unit tests, but I have verified this fixes #3917 in functional testing.
Documentation
Not to my knowledge.