Refactor Processor Count Usage #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
added
Area: Performance
Area: Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4009 +/- ##
==========================================
- Coverage 87.13% 86.91% -0.22%
==========================================
Files 56 56
Lines 16953 16953
==========================================
- Hits 14772 14735 -37
- Misses 2181 2218 +37 ☔ View full report in Codecov by Sentry. |
mtfriesen
previously approved these changes
Dec 15, 2023
mtfriesen
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the notion of "max" and "active" processor counts from the codebase, as this continued to be a source of platform specific bugs, and there is almost no real scenario where we expect the number of active processors to ever change. In these rare cases, we will just ignore these new processors.
Testing
CI/CD
Documentation
N/A