Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TCP testing to Run in Parallel #4010

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Update TCP testing to Run in Parallel #4010

merged 2 commits into from
Dec 16, 2023

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Dec 15, 2023

Description

TCP code didn't parallelize its worker before. When I enabled that, I had to fix some other issues.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner December 15, 2023 18:23
csujedihy
csujedihy previously approved these changes Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe9c297) 87.13% compared to head (15a98f3) 86.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4010      +/-   ##
==========================================
- Coverage   87.13%   86.10%   -1.04%     
==========================================
  Files          56       56              
  Lines       16953    16953              
==========================================
- Hits        14772    14597     -175     
- Misses       2181     2356     +175     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 80b4211 into main Dec 16, 2023
406 of 411 checks passed
@nibanks nibanks deleted the nibanks/parallel-tcp branch December 16, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants