-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Optional Units on secnetperf Arguments #4015
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
==========================================
- Coverage 86.95% 86.89% -0.06%
==========================================
Files 56 56
Lines 16938 16938
==========================================
- Hits 14728 14718 -10
- Misses 2210 2220 +10 ☔ View full report in Codecov by Sentry. |
I suggest "GB" rather than "gb" since both bytes and bits are used in our field |
It's generally all case insensitive. |
//" -inline:<0/1> Create new streams on callbacks. (def:0)\n" | ||
" -rconn:<0/1> Repeat the scenario at the connection level. (def:0)\n" | ||
" -rstream:<0/1> Repeat the scenario at the stream level. (def:0)\n" | ||
" -runtime:<####> The total runtime (in ms). Only relevant for repeat scenarios. (def:0)\n" | ||
" -runtime:<####>[unit] The total runtime, with an optional unit (def unit is us). Only relevant for repeat scenarios. (def:0)\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default is us, really? that seems... overly precise.
Description
Now instead of doing:
You do:
It supports both length/size units (gb, ms, kb, b) and time units (m, s, ms, us).
Testing
Tested locally. CI/CD
Documentation
Updated help text.