Support Optional Units on secnetperf Arguments #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
==========================================
- Coverage 86.95% 86.89% -0.06%
==========================================
Files 56 56
Lines 16938 16938
==========================================
- Hits 14728 14718 -10
- Misses 2210 2220 +10 ☔ View full report in Codecov by Sentry. |
|
I suggest "GB" rather than "gb" since both bytes and bits are used in our field |
It's generally all case insensitive. |
anrossi
reviewed
Jan 8, 2024
| //" -inline:<0/1> Create new streams on callbacks. (def:0)\n" | ||
| " -rconn:<0/1> Repeat the scenario at the connection level. (def:0)\n" | ||
| " -rstream:<0/1> Repeat the scenario at the stream level. (def:0)\n" | ||
| " -runtime:<####> The total runtime (in ms). Only relevant for repeat scenarios. (def:0)\n" | ||
| " -runtime:<####>[unit] The total runtime, with an optional unit (def unit is us). Only relevant for repeat scenarios. (def:0)\n" |
There was a problem hiding this comment.
default is us, really? that seems... overly precise.
csujedihy
reviewed
Jan 8, 2024
anrossi
previously approved these changes
Jan 8, 2024
csujedihy
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now instead of doing:
You do:
It supports both length/size units (gb, ms, kb, b) and time units (m, s, ms, us).
Testing
Tested locally. CI/CD
Documentation
Updated help text.