Event generation to report network statistics #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Jan 22, 2024
nibanks
reviewed
Jan 22, 2024
…TT, congestion window, bytes in flight, etc. values
ptrivedi
force-pushed
the
data-acked-event
branch
from
df79e81
to
75fa572
Compare
nibanks
reviewed
Jan 22, 2024
ptrivedi
force-pushed
the
data-acked-event
branch
from
c2c17d2
to
a852a24
Compare
nibanks
reviewed
Jan 22, 2024
ptrivedi
force-pushed
the
data-acked-event
branch
from
a852a24
to
5754b18
Compare
This event is currently triggered every time an ack arrives and data is acknowledged. * Change connection event name to QUIC_CONN_EVENT_NETWORK_STATISTICS as it could be triggered from other places to communicate net stats out. * Put NETWORK_STATISTICS event enablement feature behind a settings flag * Make NETWORK_STATISTICS event generation functionality a preview feature * Add test for NetStatsEventEnabled setting * Add test cases for QUIC_CONNECTION_EVENT_NETWORK_STATISTICS event generation
ptrivedi
force-pushed
the
data-acked-event
branch
from
5754b18
to
fe388f2
Compare
ptrivedi
changed the title
nibanks
added
Area: Performance
Area: API
Area: Core
nibanks
reviewed
Jan 24, 2024
Co-authored-by: Nick Banks <nibanks@microsoft.com>
Co-authored-by: Nick Banks <nibanks@microsoft.com>
address review comments, clean up
nibanks
reviewed
Jan 24, 2024
…into data-acked-event
ptrivedi
force-pushed
the
data-acked-event
branch
from
1d0b84f
to
b173d4f
Compare
nibanks
previously approved these changes
Jan 24, 2024
nibanks
previously approved these changes
Jan 24, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ptrivedi
force-pushed
the
data-acked-event
branch
from
ec5e39f
to
2ed449e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
==========================================
- Coverage 86.97% 86.88% -0.10%
==========================================
Files 56 56
Lines 16938 16983 +45
==========================================
+ Hits 14732 14755 +23
- Misses 2206 2228 +22 ☔ View full report in Codecov by Sentry. |
nibanks
previously approved these changes
Jan 25, 2024
nibanks
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon data acknowledgement, indicate a connection event with updated RTT, congestion window, unacknowledged bytes etc. values
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?