Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora 39 to OneBranch.Publish.yml #4095

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

sillyotter
Copy link
Contributor

Description

Add Fedora 39 to the list of rpm packages that get published

Testing

I do not believe I have the ability to force a publish, so I doubt I can test this.

Documentation

Most documentation already says dotnet core and msquic support fedora 37+, so I do not think anything needs updated.

@sillyotter sillyotter requested a review from a team as a code owner January 29, 2024 17:04
@nibanks
Copy link
Member

nibanks commented Jan 29, 2024

@csujedihy can you please verify this? We'll also want to take this for release/2.3 most likely.

@sillyotter
Copy link
Contributor Author

This is in reference to Issue #4092 raised earlier. There were questions raised there about the wider question of what is in this file and how things get chosen to be built with each parameter group, why some historical things are where they are, etc. I think this PR deals with the explicit issue I raised, but I am wondering about other issues about what gets published and when. Perhaps they can be discussed in the issue or a new conversation can be started.

Thanks

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcd5d5b) 87.24% compared to head (01ad269) 86.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4095      +/-   ##
==========================================
- Coverage   87.24%   86.25%   -0.99%     
==========================================
  Files          56       56              
  Lines       16983    16983              
==========================================
- Hits        14816    14649     -167     
- Misses       2167     2334     +167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csujedihy
Copy link
Contributor

@csujedihy can you please verify this? We'll also want to take this for release/2.3 most likely.

LGTM. The package for fedora 39 will be published when 2.3.1 is released.

@csujedihy csujedihy merged commit c1cb455 into microsoft:main Jan 29, 2024
324 of 329 checks passed
nibanks pushed a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants