Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Perl on Windows via WinGet #4348

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Install Perl on Windows via WinGet #4348

merged 3 commits into from
Jun 14, 2024

Conversation

anrossi
Copy link
Contributor

@anrossi anrossi commented Jun 14, 2024

Description

Updates the prepare-machine script to install Perl on windows for OpenSSL builds.

Testing

Ran the script locally and it worked fine.

Documentation

N/A

@anrossi anrossi requested a review from a team as a code owner June 14, 2024 01:55
nibanks
nibanks previously approved these changes Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (28ae555) to head (b664621).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4348      +/-   ##
==========================================
- Coverage   85.76%   85.15%   -0.62%     
==========================================
  Files          56       56              
  Lines       15384    15384              
==========================================
- Hits        13194    13100      -94     
- Misses       2190     2284      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ami-GS ami-GS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we don't need to install anything manually for windows anymore?

@anrossi
Copy link
Contributor Author

anrossi commented Jun 14, 2024

Now we don't need to install anything manually for windows anymore?

I hope this is the last one needed. The developer will need to add the switch on the prepare-machine command line (because the build system uses the script, so it can't be automatic), but this should make it easier.

@anrossi anrossi merged commit 466d8c9 into main Jun 14, 2024
372 of 378 checks passed
@anrossi anrossi deleted the anrossi/install-perl branch June 14, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants