-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Perl on Windows via WinGet #4348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4348 +/- ##
==========================================
- Coverage 85.76% 85.15% -0.62%
==========================================
Files 56 56
Lines 15384 15384
==========================================
- Hits 13194 13100 -94
- Misses 2190 2284 +94 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we don't need to install anything manually for windows anymore?
I hope this is the last one needed. The developer will need to add the switch on the prepare-machine command line (because the build system uses the script, so it can't be automatic), but this should make it easier. |
Description
Updates the prepare-machine script to install Perl on windows for OpenSSL builds.
Testing
Ran the script locally and it worked fine.
Documentation
N/A