-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document troubleshooting of packets using wireshark #4391
Conversation
@microsoft-github-policy-service agree |
…nd after that run the program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing this! Just a few nits
@nibanks The code is failing to compile and I assume this is because the sample is |
Please convert to C |
This looks good. I've made a couple comments on the documentation. Fix those and I'll approve as well. |
Sorry for the delay on this guys, I'll update them as soon as I have some free time. I plan doing this tomorrow. |
Finally had some free time, I ported the code back to C and tested locally and everything seems to be working just fine. Any changes please let me know. If no changes are required and the pipeline pass we can merge this. Thanks guys. Also @nibanks it would be a good idea to add the https://microsoft.github.io/msquic/msquicdocs/ website to this repo. |
Looks like every Windows build failed:
|
I think you need to include |
Added as required. I cannot test this on my machine since I don't have windows installed but I did the same way other places where including it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4391 +/- ##
==========================================
- Coverage 85.02% 85.00% -0.03%
==========================================
Files 56 56
Lines 15457 15457
==========================================
- Hits 13143 13139 -4
- Misses 2314 2318 +4 ☔ View full report in Codecov by Sentry. |
Description
Add documentation on how to troubleshoot quic packets using wireshark
Testing
This is not a change to the library itself, just a change in a sample program that uses MsQuic.
Documentation
This change the Diagnostics documentation adding a description on how to troubleshoot packets using wireshark.