Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global internal param to get default datapath worker pool #4535

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

ThadHouse
Copy link
Contributor

Description

Before #4492, it was possible for apps statically linking to MsQuic and CxPLat to get the default worker pool used by Quic. After that PR, the default worker pool is no longer accessible. Add a new global param getter to make that accessable.

Testing

Added test to cover the new parameter.

Documentation

Internal, so not documented.

@ThadHouse ThadHouse requested a review from a team as a code owner September 7, 2024 23:16
src/inc/msquicp.h Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (9f2f0d4) to head (1233899).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/library.c 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4535      +/-   ##
==========================================
- Coverage   86.19%   85.93%   -0.27%     
==========================================
  Files          56       56              
  Lines       15520    15530      +10     
==========================================
- Hits        13378    13346      -32     
- Misses       2142     2184      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks added the external Proposed by non-MSFT label Sep 8, 2024
submodules/googletest Outdated Show resolved Hide resolved
nibanks
nibanks previously approved these changes Sep 8, 2024
@nibanks nibanks merged commit fb96220 into microsoft:main Sep 8, 2024
467 of 471 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants