Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out remote and local addresses on TCP server connection #4537

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

ThadHouse
Copy link
Contributor

Description

TCP accepted connections did not have a filled out remote or local address. Fill them out.

Testing

Update the connect test to assert things are valid.

Documentation

N/A

@ThadHouse ThadHouse requested a review from a team as a code owner September 8, 2024 06:00
nibanks
nibanks previously approved these changes Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (9f2f0d4) to head (b5ae015).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4537      +/-   ##
==========================================
- Coverage   86.19%   85.79%   -0.41%     
==========================================
  Files          56       56              
  Lines       15520    15520              
==========================================
- Hits        13378    13315      -63     
- Misses       2142     2205      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks added the external Proposed by non-MSFT label Sep 8, 2024
@nibanks
Copy link
Member

nibanks commented Sep 8, 2024

Linux build errors:

/home/runner/work/msquic/msquic/src/platform/datapath_epoll.c: In function ‘CxPlatSocketContextAcceptCompletion’:
/home/runner/work/msquic/msquic/src/platform/datapath_epoll.c:1544:41: error: ‘SocketContext->AcceptSocket’ is a pointer; did you mean to use ‘->’?
 1544 |             &SocketContext->AcceptSocket.RemoteAddress,
      |                                         ^
      |                                         ->
/home/runner/work/msquic/msquic/src/platform/datapath_epoll.c:1545:47: error: ‘SocketContext->AcceptSocket’ is a pointer; did you mean to use ‘->’?
 1545 |             sizeof(SocketContext->AcceptSocket.RemoteAddress));
      |                                               ^
      |                                               ->
/home/runner/work/msquic/msquic/src/platform/datapath_epoll.c:[1560](https://github.com/microsoft/msquic/actions/runs/10757524322/job/29834912584?pr=4537#step:6:1561):41: error: ‘SocketContext->AcceptSocket’ is a pointer; did you mean to use ‘->’?
 1560 |             &SocketContext->AcceptSocket.LocalAddress,
      |                                         ^
      |                                         ->
/home/runner/work/msquic/msquic/src/platform/datapath_epoll.c:[1561](https://github.com/microsoft/msquic/actions/runs/10757524322/job/29834912584?pr=4537#step:6:1562):47: error: ‘SocketContext->AcceptSocket’ is a pointer; did you mean to use ‘->’?
 1561 |             sizeof(SocketContext->AcceptSocket.LocalAddress));
      |                                               ^
      |                                               ->

submodules/googletest Outdated Show resolved Hide resolved
nibanks
nibanks previously approved these changes Sep 8, 2024
@nibanks nibanks merged commit 1554d42 into microsoft:main Sep 9, 2024
470 of 471 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants