Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set EPOLLOUT when creating TCP sockets #4542

Closed
wants to merge 1 commit into from

Conversation

ThadHouse
Copy link
Contributor

Description

Epollout shouldn't be set until a pending send is available.

Testing

Not easy to test because there isn't really a failure case, but the UDP side explicitly adds epollout only when needed.

Documentation

N/A

@ThadHouse ThadHouse requested a review from a team as a code owner September 9, 2024 07:51
@nibanks nibanks added external Proposed by non-MSFT Bug: Platform A code bug in platform/TLS specific code. labels Sep 9, 2024
@nibanks
Copy link
Member

nibanks commented Sep 9, 2024

Lots of BVT failures

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.96%. Comparing base (fb96220) to head (75368f1).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4542      +/-   ##
==========================================
- Coverage   86.41%   85.96%   -0.46%     
==========================================
  Files          56       56              
  Lines       15530    15530              
==========================================
- Hits        13421    13351      -70     
- Misses       2109     2179      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThadHouse ThadHouse closed this Sep 9, 2024
@ThadHouse
Copy link
Contributor Author

I guess you actually do need epollout set for connect() to work.

@ThadHouse ThadHouse deleted the tcpepollout branch September 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Platform A code bug in platform/TLS specific code. external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants