Test | Improvements in LobsTest exception and failure handling (#1008)

microsoft · Mar 28, 2019 · a89a909 · a89a909
1 parent 98b1097
commit a89a909
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/test/java/com/microsoft/sqlserver/jdbc/unit/lobs/LobsTest.java b/src/test/java/com/microsoft/sqlserver/jdbc/unit/lobs/LobsTest.java
@@ -4,6 +4,7 @@
  */
 package com.microsoft.sqlserver.jdbc.unit.lobs;
 
+import static org.junit.Assert.fail;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
@@ -156,6 +157,7 @@ private void testInvalidLobs(Class<?> lobClass, boolean isResultSet) throws SQLE
                     }
                     try {
                         this.updateLob(lob, updater, 1);
+                        fail(TestResource.getResource("R_expectedFailPassed"));
                     } catch (SQLException e) {
                         boolean verified = false;
 
@@ -199,7 +201,7 @@ else if (lobClass == Blob.class)
                     }
                 }
             } catch (Exception e) {
-                e.printStackTrace();
+                fail(e.getMessage());
             } finally {
                 dropTables(table, stmt1);
                 if (null != updater) {
@@ -245,17 +247,20 @@ private void testFreedBlobs(Class<?> lobClass, boolean isResultSet) throws SQLEx
                                 stream.read();
                             blob.free();
                         }
-                        try (InputStream stream = blob.getBinaryStream()) {} catch (SQLException e) {
-                            System.err.println(e.getMessage());
+                        try (InputStream stream = blob.getBinaryStream()) {
+                            fail(TestResource.getResource("R_expectedFailPassed"));
+                        } catch (SQLException e) {
                             assertTrue(e.getMessage().contains(TestResource.getResource("R_blobFreed")));
                         }
                     }
                 }
-                try (InputStream stream = blob.getBinaryStream()) {} catch (SQLException e) {
+                try (InputStream stream = blob.getBinaryStream()) {
+                    fail(TestResource.getResource("R_expectedFailPassed"));
+                } catch (SQLException e) {
                     assertTrue(e.getMessage().contains(TestResource.getResource("R_blobFreed")));
                 }
             } catch (Exception e) {
-                e.printStackTrace();
+                fail(e.getMessage());
             } finally {
                 dropTables(table, stmt);
             }