Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STAsBinary returning null for a single point #1074

Merged
merged 4 commits into from
Sep 19, 2019

Conversation

peterbae
Copy link
Contributor

@peterbae peterbae commented Jun 3, 2019

Fixes issue #1073.

@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #1074 into dev will decrease coverage by 0.37%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1074      +/-   ##
============================================
- Coverage     53.45%   53.08%   -0.38%     
+ Complexity     3235     3172      -63     
============================================
  Files           119      119              
  Lines         28036    28048      +12     
  Branches       4680     4686       +6     
============================================
- Hits          14988    14889      -99     
- Misses        10904    10937      +33     
- Partials       2144     2222      +78
Impacted Files Coverage Δ Complexity Δ
...osoft/sqlserver/jdbc/SQLServerSpatialDatatype.java 85.57% <95.65%> (+0.08%) 294 <20> (+5) ⬆️
...soft/sqlserver/jdbc/SQLServerPooledConnection.java 76.84% <0%> (-4.22%) 26% <0%> (-4%)
...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java 56.25% <0%> (-3.75%) 5% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 43.95% <0%> (-3.3%) 15% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 53.31% <0%> (-1.87%) 216% <0%> (-32%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.86% <0%> (-1.52%) 111% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 74.28% <0%> (-1.43%) 33% <0%> (-2%)
...SQLServerColumnEncryptionJavaKeyStoreProvider.java 63.12% <0%> (-1.42%) 10% <0%> (-2%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 59.76% <0%> (-1.19%) 34% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 61.03% <0%> (-1.06%) 0% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ecbdc...63b6e2d. Read the comment docs.

@ulvii ulvii added this to In progress in MSSQL JDBC Jun 25, 2019
@ulvii ulvii added this to the 7.5.0 milestone Aug 12, 2019
lilgreenbird
lilgreenbird previously approved these changes Aug 27, 2019
@peterbae peterbae merged commit 7dd953e into microsoft:dev Sep 19, 2019
MSSQL JDBC automation moved this from In progress to Closed/Merged PRs Sep 19, 2019
ulvii added a commit that referenced this pull request Oct 16, 2019
* Release | Update SNAPSHOT for 7.5.0-preview release (#1129)

* Release | Update driver version

* Release| Add pom and gradle files

* Fix | Remove extra spaces in SQLServerDatabaseMetaData.getNumericFunctions()/SQLServerDatabaseMetaData.getStringFunctions() return values (#1117)

* Tests | Improve assertions in ComparisonUtil (#1100)

* ComparisonUtil : replace assertTrue with assertEquals

Failure message should include the actual/expected values and that is what assertEquals does.

* Corrected BigDecimal comparison

Scale difference should be ignored.

* Fix | Add list of trusted endpoints for AKV (#1130)

* added list of trusted endpoints

* rename

* Update issue templates (#1148)

* Fix getImportedKeys() returning duplicate rows if multiple FKs have the same name  (#1092)

* fixed for github #1091 dup rows

* Fix STAsBinary returning null for a single point (#1074)

* populate wkb for point

* fix stasbinary issue

* change variable name

* apply same variable name change

* Performance | Improved performance of column name string lookups (#1066)

* Fix | Made column name lookup more performant

* Fix | Spacing

* Fix | Changed arraylist to maps

* Fix | Add newline

* Add | Caching for previously retrieved columns

* Fix | Formatting

* Fix | Variable issue

* Fix | null order

* Fix | part 2

* Revert | Integer changes

* Fix | Trim retrieved column name

* Fix | Clear column names whenever ResultSet cursor is moved

* Revert "Fix | Clear column names whenever ResultSet cursor is moved"

This reverts commit db42d44.

* Add | Implement hashCode() and equals() APIs for SQLServerDataTable and SQLServerDataColumn (#1146)

* Add | Add hashCode()/equals() methods to SQLServerDataColumn and SQLServerDataTable

* Fix issue with truststore password being removed too early for XA transaction (#1133)

Fix | Fix issue with truststore password being removed too early for XA transaction

* Fix | SQLServerDatabaseMetada.getColumns not escaping wildcard (#1138)

* Feature | Introduce JAVA 13 Support (#1151)

* JDK 13 | Remove jre12 from pom file

* JDK 13 | Update Gradle build file

* JDK 13 | Update Azure-pipelines

* Test | Updated SQL Server from 2008R2 to 2012 in CI (#1153)

* Performance | Disabled pattern matching when using CallableStatements and SQLServerParameterMetaData (#1149)

* Fix | Added ISQLServerBulkData to remove implementation details from ISQLServerBulkRecord (#1099)

* Feature | Added support for Always Encrypted with Secure Enclaves (#1155)

* Release | 8.1.0-preview release changes (#1158)
ulvii pushed a commit that referenced this pull request Mar 3, 2020
* populate wkb for point

* fix stasbinary issue

* change variable name

* apply same variable name change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

5 participants