Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance | Improved performance of column name string lookups #1066

Merged
merged 14 commits into from
Sep 24, 2019
Merged

Performance | Improved performance of column name string lookups #1066

merged 14 commits into from
Sep 24, 2019

Conversation

rene-ye
Copy link
Member

@rene-ye rene-ye commented May 22, 2019 •
edited
Loading

Addresses #1055.

@rene-ye rene-ye mentioned this pull request May 22, 2019
Closed
@rene-ye rene-ye changed the title Fix | Made column name lookup more performant Fix | Improved performance of column name string lookups May 22, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone May 22, 2019
@cheenamalhotra cheenamalhotra added this to Under Peer Review in MSSQL JDBC May 22, 2019
@codecov-io
Copy link

codecov-io commented May 23, 2019 •
edited
Loading

Codecov Report

Merging #1066 into dev will decrease coverage by 1.58%.
The diff coverage is 83.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1066      +/-   ##
============================================
- Coverage     54.56%   52.97%   -1.59%     
+ Complexity     3370     3162     -208     
============================================
  Files           124      119       -5     
  Lines         28775    28031     -744     
  Branches       4772     4677      -95     
============================================
- Hits          15700    14849     -851     
- Misses        10793    10964     +171     
+ Partials       2282     2218      -64
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 44.27% <83.33%> (-0.03%) 328 <5> (-1)
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 29.15% <84.21%> (-0.45%) 97 <8> (-3)
...com/microsoft/sqlserver/jdbc/dns/DNSUtilities.java 0% <0%> (-81.49%) 0% <0%> (-4%)
.../java/com/microsoft/sqlserver/jdbc/StreamSSPI.java 0% <0%> (-66.67%) 0% <0%> (-3%)
...m/microsoft/sqlserver/jdbc/SSPIAuthentication.java 0% <0%> (-56.25%) 0% <0%> (-12%)
...crosoft/sqlserver/jdbc/dns/DNSKerberosLocator.java 0% <0%> (-37.5%) 0% <0%> (-1%)
...com/microsoft/sqlserver/jdbc/dns/DNSRecordSRV.java 0% <0%> (-33.97%) 0% <0%> (-4%)
...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java 47.96% <0%> (-12.2%) 29% <0%> (-8%)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 36.18% <0%> (-3.63%) 70% <0%> (-6%)
...ava/com/microsoft/sqlserver/jdbc/FailOverInfo.java 52.63% <0%> (-3.51%) 0% <0%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd953e...c99be92. Read the comment docs.

@cheenamalhotra cheenamalhotra changed the title Fix | Improved performance of column name string lookups Performance | Improved performance of column name string lookups May 27, 2019
@rene-ye rene-ye removed this from the 7.3.1 milestone May 28, 2019
@rene-ye rene-ye added this to the 7.3.1 milestone May 30, 2019
@rene-ye rene-ye removed this from the 7.3.1 milestone Jun 6, 2019
@ulvii ulvii added this to the 7.5.0 milestone Aug 12, 2019
@rene-ye
Merge branch 'dev' of https://github.com/Microsoft/mssql-jdbc into is…
8bf02c3 
…sue1055

# Conflicts:
#	src/main/java/com/microsoft/sqlserver/jdbc/SQLServerCallableStatement.java
peterbae
peterbae previously approved these changes Sep 23, 2019
View reviewed changes
ulvii
ulvii previously approved these changes Sep 23, 2019
View reviewed changes
@rene-ye rene-ye dismissed stale reviews from ulvii and peterbae via db42d44 September 24, 2019 15:56
@rene-ye rene-ye merged commit b424b77 into microsoft:dev Sep 24, 2019
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Sep 24, 2019
@rene-ye rene-ye deleted the issue1055 branch October 10, 2019 23:07
ulvii added a commit that referenced this pull request Oct 16, 2019
@ulvii
Release | Merge dev to master for v8.1.0-preview (#1161)
e88884c 
* Release | Update SNAPSHOT for 7.5.0-preview release (#1129)

* Release | Update driver version

* Release| Add pom and gradle files

* Fix | Remove extra spaces in SQLServerDatabaseMetaData.getNumericFunctions()/SQLServerDatabaseMetaData.getStringFunctions() return values (#1117)

* Tests | Improve assertions in ComparisonUtil (#1100)

* ComparisonUtil : replace assertTrue with assertEquals

Failure message should include the actual/expected values and that is what assertEquals does.

* Corrected BigDecimal comparison

Scale difference should be ignored.

* Fix | Add list of trusted endpoints for AKV (#1130)

* added list of trusted endpoints

* rename

* Update issue templates (#1148)

* Fix getImportedKeys() returning duplicate rows if multiple FKs have the same name  (#1092)

* fixed for github #1091 dup rows

* Fix STAsBinary returning null for a single point (#1074)

* populate wkb for point

* fix stasbinary issue

* change variable name

* apply same variable name change

* Performance | Improved performance of column name string lookups (#1066)

* Fix | Made column name lookup more performant

* Fix | Spacing

* Fix | Changed arraylist to maps

* Fix | Add newline

* Add | Caching for previously retrieved columns

* Fix | Formatting

* Fix | Variable issue

* Fix | null order

* Fix | part 2

* Revert | Integer changes

* Fix | Trim retrieved column name

* Fix | Clear column names whenever ResultSet cursor is moved

* Revert "Fix | Clear column names whenever ResultSet cursor is moved"

This reverts commit db42d44.

* Add | Implement hashCode() and equals() APIs for SQLServerDataTable and SQLServerDataColumn (#1146)

* Add | Add hashCode()/equals() methods to SQLServerDataColumn and SQLServerDataTable

* Fix issue with truststore password being removed too early for XA transaction (#1133)

Fix | Fix issue with truststore password being removed too early for XA transaction

* Fix | SQLServerDatabaseMetada.getColumns not escaping wildcard (#1138)

* Feature | Introduce JAVA 13 Support (#1151)

* JDK 13 | Remove jre12 from pom file

* JDK 13 | Update Gradle build file

* JDK 13 | Update Azure-pipelines

* Test | Updated SQL Server from 2008R2 to 2012 in CI (#1153)

* Performance | Disabled pattern matching when using CallableStatements and SQLServerParameterMetaData (#1149)

* Fix | Added ISQLServerBulkData to remove implementation details from ISQLServerBulkRecord (#1099)

* Feature | Added support for Always Encrypted with Secure Enclaves (#1155)

* Release | 8.1.0-preview release changes (#1158)
@ulvii ulvii mentioned this pull request Oct 16, 2019
Merged
ulvii pushed a commit that referenced this pull request Mar 3, 2020
@rene-ye
Performance | Improved performance of column name string lookups (#1066)
2c5f99d 
* Fix | Made column name lookup more performant

* Fix | Spacing

* Fix | Changed arraylist to maps

* Fix | Add newline

* Add | Caching for previously retrieved columns

* Fix | Formatting

* Fix | Variable issue

* Fix | null order

* Fix | part 2

* Revert | Integer changes

* Fix | Trim retrieved column name

* Fix | Clear column names whenever ResultSet cursor is moved

* Revert "Fix | Clear column names whenever ResultSet cursor is moved"

This reverts commit db42d44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra left review comments

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae left review comments

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rene-ye @codecov-io @lilgreenbird @cheenamalhotra @ulvii @peterbae