Refactor Idle Connection Resiliency timeout to use existing SharedTimer #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Engel
requested review from
VeryVerySpicy,
Jeffery-Wasty,
lilgreenbird and
tkyc
lilgreenbird
changed the title
lilgreenbird
reviewed
Apr 9, 2022
| this.command = cmd; | ||
| connectRetryCount = con.getRetryCount(); | ||
| eReceived = null; | ||
| stopRequested = false; | ||
| if (loggerExternal.isLoggable(Level.FINER)) { | ||
| loggerExternal.finer("ICR reconnect thread initialized. Connection retry count = " + connectRetryCount |
There was a problem hiding this comment.
don't use ICR acronym? (multiple occurences)
lilgreenbird
reviewed
Apr 9, 2022
| while ((connectRetryCount != 0) && (!stopRequested) && keepRetrying) { | ||
| while ((connectRetryCount > 0) && (!stopRequested) && keepRetrying) { | ||
| if (loggerExternal.isLoggable(Level.FINER)) { | ||
| loggerExternal.finer("Running ICR reconnect for command: " + command.toString()); |
There was a problem hiding this comment.
[nitpick] combine both to just 1 call?
Jeffery-Wasty
previously approved these changes
Apr 12, 2022
VeryVerySpicy
previously approved these changes
Apr 12, 2022
tkyc
previously approved these changes
Apr 12, 2022
David-Engel
dismissed stale reviews from tkyc, VeryVerySpicy, and Jeffery-Wasty
via
46326d8
Jeffery-Wasty
approved these changes
Apr 14, 2022
lilgreenbird
approved these changes
Apr 14, 2022
VeryVerySpicy
approved these changes
Apr 14, 2022
tkyc
approved these changes
Apr 14, 2022
This was referenced Apr 14, 2022
This was referenced May 9, 2022
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ICR feature brought in a previous timeout implementation that had drawbacks. This changes ICR to use the current SharedTimer, which is much more efficient.
This PR obsoletes #1782 and #1789 since it completely removes the class being updated in those two PRs.
EDIT: While testing, discovered that ICR also fails to reconnect a connection that has already been recovered once by ICR. This is also fixed in this PR.