Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube fixes #301

Merged
merged 15 commits into from
May 25, 2017
Merged

Conversation

AfsanehR-zz
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented May 18, 2017

Codecov Report

Merging #301 into RTW_6.2.0 will increase coverage by 0.17%.
The diff coverage is 59.45%.

Impacted file tree graph

@@               Coverage Diff               @@
##             RTW_6.2.0     #301      +/-   ##
===============================================
+ Coverage         37.2%   37.37%   +0.17%     
- Complexity        1664     1676      +12     
===============================================
  Files              103      103              
  Lines            23674    23684      +10     
  Branches          3882     3880       -2     
===============================================
+ Hits              8808     8853      +45     
+ Misses           13275    13245      -30     
+ Partials          1591     1586       -5
Flag Coverage Δ Complexity Δ
#JDBC41 37.21% <59.45%> (+0.09%) 1666 <1> (+6) ⬆️
#JDBC42 37.23% <59.45%> (+0.11%) 1669 <1> (+9) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 48.88% <ø> (-0.38%) 10 <0> (ø)
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 25.64% <0%> (ø) 30 <0> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 36.99% <0%> (+0.16%) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.08% <0%> (ø) 129 <0> (ø) ⬇️
...java/com/microsoft/sqlserver/jdbc/StringUtils.java 37.5% <50%> (-22.5%) 4 <1> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 47.27% <90.9%> (+2.11%) 60 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.01% <0%> (-0.08%) 212% <0%> (ø)
...com/microsoft/sqlserver/jdbc/dns/DNSUtilities.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85245a...137bbea. Read the comment docs.

Copy link

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that 1 change, everything else looks good

@@ -791,7 +792,7 @@ else if (-1 != version.indexOf('.')) {
/* L0 */ public Xid[] recover(int flags) throws XAException {
XAReturnValue r = DTC_XA_Interface(XA_RECOVER, null, flags | tightlyCoupled);
int offset = 0;
Vector<XidImpl> v = new Vector<XidImpl>();
ArrayList<XidImpl> v = new ArrayList<XidImpl>();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the variable name doesnt mean anything anymore now that its an array list instead of a vector. It might be better to rename it to something like al

@AfsanehR-zz AfsanehR-zz merged commit 5718b5b into microsoft:RTW_6.2.0 May 25, 2017
@AfsanehR-zz AfsanehR-zz deleted the SonarQube_fixes branch February 2, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants