Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing any CPU model while invoking QEMU. #669

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Allow passing any CPU model while invoking QEMU. #669

merged 4 commits into from
Aug 30, 2023

Conversation

NishanthSanjeevi
Copy link
Contributor

@NishanthSanjeevi NishanthSanjeevi commented Aug 17, 2023 •
edited by makubacki
Loading

Description

  • Added CpuInfoDxe driver that prints the basic information about the CPU model invoked by QEMU.

  • Added a command line argument to pass the CPU model to be used while invoking QEMU

  • Added basic tests to validate the CPU model being used

  • Impacts functionality?
    Added a new driver that prints CPU model information

  • Impacts security?
    N/A

  • Breaking change?
    N/A

  • Includes tests?
    N/A

  • Includes documentation?
    No

How This Was Tested

Validated the changes on QEMU

Integration Instructions

N/A

@NishanthSanjeevi
Feature/qemu cpu models support (#1)
73de309 
* Add CpuInfoDxe driver

* Add flag to pass CPU model

* Add basic tests
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Aug 17, 2023
@NishanthSanjeevi NishanthSanjeevi changed the title Feature/qemu cpu models support (#1) Allow passing any CPU model while invoking QEMU. Aug 17, 2023
os-d
os-d approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Michael's comments addressed, LGTM

@makubacki
Copy link
Member

@NishanthSanjeevi, it would be great to get this PR merged. Please let me know if you have any questions about the feedback.

makubacki
makubacki approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@makubacki makubacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming feedback is addressed.

@makubacki makubacki enabled auto-merge (squash) August 30, 2023 03:35
@makubacki makubacki added type:feature-request A new feature proposal and removed impact:non-functional Does not have a functional impact labels Aug 30, 2023
@makubacki makubacki merged commit 53b5b7f into microsoft:main Aug 30, 2023
25 checks passed
@makubacki makubacki mentioned this pull request Feb 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makubacki makubacki makubacki approved these changes

@os-d os-d os-d approved these changes

@apop5 apop5 apop5 approved these changes

@cfernald cfernald Awaiting requested review from cfernald

Assignees
No one assigned
Labels
language:python Pull requests that update Python code type:feature-request A new feature proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NishanthSanjeevi @makubacki @os-d @apop5