Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FmpDevicePkg: Assert on PcdFmpDeviceImageTypeIdGuid Size Mismatch #299

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Jul 3, 2024

Description

This patch adds an assert to FmpDxe.c to catch a platform misconfiguration of PcdFmpDeviceImageTypeIdGuid.

Cherry-picked from 8abe685.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

From 2311.

Integration Instructions

N/A.

@os-d os-d requested review from makubacki and apop5 July 3, 2024 23:00
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jul 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202405@3bbf289). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #299   +/-   ##
=================================================
  Coverage                  ?   33.21%           
=================================================
  Files                     ?        1           
  Lines                     ?      289           
  Branches                  ?      106           
=================================================
  Hits                      ?       96           
  Misses                    ?      114           
  Partials                  ?       79           
Flag Coverage Δ
FmpDevicePkg 33.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This patch adds an assert to FmpDxe.c to catch a platform
misconfiguration of PcdFmpDeviceImageTypeIdGuid.
@os-d os-d enabled auto-merge (rebase) July 4, 2024 15:35
@os-d os-d merged commit 14a359e into microsoft:release/202405 Jul 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants