Skip to content

Commit

Permalink
fix bug of detail page broken when succeeded trial without final resu…
Browse files Browse the repository at this point in the history
…lt (#1472)

* Update filter description and fix typo

* fix comments

* change node to result

* Add SupportTrainingService.md (#1401)

* fix nnictl schema

* Eject from react-scripts-ts-antd and bump webui dependencies version (#1412)

* Eject from react-scripts-ts-antd

* test whether it can pass CI without ugilfy

* temporarily disable uglify

* Try to fix security alert (#1429)

* fix bug of detail page broken when trial is succeed but not report final result
  • Loading branch information
lvybriage authored and liuzhe-lz committed Aug 20, 2019
1 parent 7b75539 commit 33feb6e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/webui/src/components/trial-detail/DefaultMetricPoint.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ class DefaultPoint extends React.Component<DefaultPointProps, DefaultPointState>
});
// deal with best metric line
const bestCurve: Array<number | object>[] = []; // best curve data source
bestCurve.push([lineListDefault[0][0], lineListDefault[0][1], accSource[0].searchSpace]);
if (lineListDefault[0] !== undefined) {
bestCurve.push([lineListDefault[0][0], lineListDefault[0][1], accSource[0].searchSpace]);
}
if (optimize === 'maximize') {
for (let i = 1; i < lineListDefault.length; i++) {
const val = lineListDefault[i][1];
Expand Down
5 changes: 3 additions & 2 deletions src/webui/src/static/style/table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@
}

#detail-button{
margin: 2px 0;
.common-style, .common-style:visited, .common-style:focus{
height: 26px;
border: none;
Expand All @@ -131,7 +132,7 @@
.common-style:disabled{
background-color: #f4f4f4;
}
.special, .special:visited, .special:focus{
.special, .special:visited, .special:focus, .special button{
height: 26px;
border: none;
border-radius: 0;
Expand All @@ -146,7 +147,7 @@
background-color: #c8c8c8;
outline: 0;
}
.special:disabled{
.special:disabled, .special button:disabled{
background-color: #f4f4f4;
color: #d9d9d9;
}
Expand Down

0 comments on commit 33feb6e

Please sign in to comment.