Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Eject from react-scripts-ts-antd and bump webui dependencies version #1412

Merged
merged 4 commits into from
Aug 7, 2019

Conversation

liuzhe-lz
Copy link
Contributor

@liuzhe-lz liuzhe-lz commented Aug 5, 2019

To solve the security alert, we must upgrade to webpack v4, which is incompatible with react-scripts-ts-antd.
I have checked the repo of react-scripts-ts-antd as well as it's upstream react-scripts-ts, and confirmed that both of them are no longer maintained.
So I believe it's time to eject.

Note: This PR requires a clean build! (i.e. make clean before make)
Please check if it works with your devices.

Known issues:

  • The version of react and its type annotation are not perfectly matched.
  • Some plugins are deprecated or unmaintained in webpack v4.
  • The scripts are auto-generated and are somewhat redundant.
  • The memory-hungry uglify plugin is temporarily disabled to pass the CI pipeline. We should enable webpack's built-in uglifier in next release.

@liuzhe-lz
Copy link
Contributor Author

For reviewers:
This PR, especially files in src/webui/scripts and src/webui/config folders, are mostly generated with yarn eject command.
Instead of manually reading diff files, please pull the branch to your device and try it out.

@liuzhe-lz liuzhe-lz changed the title Eject from react-scripts-ts-antd and bump webui dependencies version [Not Ready] Eject from react-scripts-ts-antd and bump webui dependencies version Aug 5, 2019
@suiguoxin suiguoxin mentioned this pull request Aug 5, 2019
44 tasks
@suiguoxin suiguoxin mentioned this pull request Aug 6, 2019
66 tasks
@liuzhe-lz liuzhe-lz changed the title [Not Ready] Eject from react-scripts-ts-antd and bump webui dependencies version Eject from react-scripts-ts-antd and bump webui dependencies version Aug 7, 2019
@liuzhe-lz liuzhe-lz merged commit ebff677 into microsoft:master Aug 7, 2019
liuzhe-lz added a commit that referenced this pull request Aug 7, 2019
…1412)

* Eject from react-scripts-ts-antd

* test whether it can pass CI without ugilfy

* temporarily disable uglify
liuzhe-lz pushed a commit that referenced this pull request Aug 14, 2019
* Update filter description and fix typo

* fix comments

* change node to result

* Add SupportTrainingService.md (#1401)

* fix nnictl schema

* Eject from react-scripts-ts-antd and bump webui dependencies version (#1412)

* Eject from react-scripts-ts-antd

* test whether it can pass CI without ugilfy

* temporarily disable uglify

* Try to fix security alert (#1429)

* fix bug of hyper-parameter broken when have not succeeded trial

* update

* update
liuzhe-lz pushed a commit that referenced this pull request Aug 20, 2019
…lt (#1472)

* Update filter description and fix typo

* fix comments

* change node to result

* Add SupportTrainingService.md (#1401)

* fix nnictl schema

* Eject from react-scripts-ts-antd and bump webui dependencies version (#1412)

* Eject from react-scripts-ts-antd

* test whether it can pass CI without ugilfy

* temporarily disable uglify

* Try to fix security alert (#1429)

* fix bug of detail page broken when trial is succeed but not report final result
@liuzhe-lz liuzhe-lz deleted the bump-webui branch November 6, 2019 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants