Eject from react-scripts-ts-antd and bump webui dependencies version #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reviewers: |
liuzhe-lz
changed the title
44 tasks
66 tasks
liuzhe-lz
changed the title
QuanluZhang
approved these changes
Aug 7, 2019
lvybriage
approved these changes
Aug 7, 2019
chicm-ms
approved these changes
Aug 7, 2019
liuzhe-lz
added a commit
that referenced
this pull request
Aug 7, 2019
…1412) * Eject from react-scripts-ts-antd * test whether it can pass CI without ugilfy * temporarily disable uglify
liuzhe-lz
pushed a commit
that referenced
this pull request
Aug 14, 2019
* Update filter description and fix typo * fix comments * change node to result * Add SupportTrainingService.md (#1401) * fix nnictl schema * Eject from react-scripts-ts-antd and bump webui dependencies version (#1412) * Eject from react-scripts-ts-antd * test whether it can pass CI without ugilfy * temporarily disable uglify * Try to fix security alert (#1429) * fix bug of hyper-parameter broken when have not succeeded trial * update * update
liuzhe-lz
pushed a commit
that referenced
this pull request
Aug 20, 2019
…lt (#1472) * Update filter description and fix typo * fix comments * change node to result * Add SupportTrainingService.md (#1401) * fix nnictl schema * Eject from react-scripts-ts-antd and bump webui dependencies version (#1412) * Eject from react-scripts-ts-antd * test whether it can pass CI without ugilfy * temporarily disable uglify * Try to fix security alert (#1429) * fix bug of detail page broken when trial is succeed but not report final result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve the security alert, we must upgrade to webpack v4, which is incompatible with
react-scripts-ts-antd.I have checked the repo of
react-scripts-ts-antdas well as it's upstreamreact-scripts-ts, and confirmed that both of them are no longer maintained.So I believe it's time to
eject.Note: This PR requires a clean build! (i.e.
make cleanbeforemake)Please check if it works with your devices.
Known issues: