-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug of hyper-parameter broken when have not succeeded trial #1460
Changes from 13 commits
508baeb
bae59fe
473c89a
6c9d370
704b50e
e42b06c
834985b
0900fc7
58fe520
2a1c3ba
18c7bd1
3a614cf
f3e09b2
fc83b6d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -238,15 +238,19 @@ class Para extends React.Component<ParaProps, ParaState> { | |
}, | ||
axisLabel: { | ||
formatter: function (value: string) { | ||
const length = value.length; | ||
if (length > 16) { | ||
const temp = value.split(''); | ||
for (let m = 16; m < temp.length; m += 17) { | ||
temp[m] += '\n'; | ||
if (value !== undefined) { | ||
const length = value.length; | ||
if (length > 16) { | ||
const temp = value.split(''); | ||
for (let m = 16; m < temp.length; m += 17) { | ||
temp[m] += '\n'; | ||
} | ||
return temp.join(''); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's better to split the string into 17-char chunks with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, I will try it in next version. |
||
} else { | ||
return value; | ||
} | ||
return temp.join(''); | ||
} else { | ||
return value; | ||
return null; | ||
} | ||
} | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type annotation says it can't be
undefined
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will add it.