fix bug of hyper-parameter broken when have not succeeded trial #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
Update filter description and fix typo
Quick fix nnictl schema TPE issue
…icrosoft#1412) * Eject from react-scripts-ts-antd * test whether it can pass CI without ugilfy * temporarily disable uglify
liuzhe-lz
reviewed
Aug 13, 2019
| const temp = value.split(''); | ||
| for (let m = 16; m < temp.length; m += 17) { | ||
| temp[m] += '\n'; | ||
| if (value !== undefined) { |
There was a problem hiding this comment.
The type annotation says it can't be undefined?
liuzhe-lz
reviewed
Aug 13, 2019
| for (let m = 16; m < temp.length; m += 17) { | ||
| temp[m] += '\n'; | ||
| } | ||
| return temp.join(''); |
There was a problem hiding this comment.
I think it's better to split the string into 17-char chunks with substring/slice and then join them with \n.
Just a personal opinion.
There was a problem hiding this comment.
Thanks, I will try it in next version.
squirrelsc
approved these changes
Aug 14, 2019
liuzhe-lz
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.