-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-pty doesn't build on Node 12 (V8 7.4) #279
Comments
Looks like nan needs to be upgraded? Feel free to do a PR for this, I likely won't look into it until Electron reaches node 12 |
@Tyriar The just released Electron 5 has already node 12 in it: |
@gpetrov yep, it'll likely take some time for VS Code to get exploration builds together for v5. Again feel free to look into this if you need it faster than us. |
thanks @Tyriar, I will see what I can do. We are using node-pty on NWJS and it is much further than Electron. Already on Chrome 74 and Node 12. I also noticed:
Thanks for you great work btw - it helped us a lot to get a full functional terminal on Windows. |
I've got it to compile in Eugeny@cb3b3f6, but there's a weird problem that seems to be related to calling Using |
@Eugeny hmm, nothing standing out as obviously wrong from the diff, the error sounds like exitCallback on the native side is being assigned to |
@Tyriar I've checked I've tried saving the v8::Context with the callback just in case, to no avail |
TBH I'm at loss here @Tyriar - spent a few hours tinkering with the callback and still got nothing. I'm not nearly as deep in Node native development, so there must be something obvious I'm missing |
Found it - weirdly enough it was the uninitialized |
I have tried to install node-pty using node 12.3.1 and 12.0.0, neither worked, with node 11.15.0 it works... should I reopen this issue or file a new one? |
Responded on your #319 |
node-pty does not build with v12 because of microsoft/node-pty#279
I had same errors on my console but the code is working fine after the install is done and i am using node v10.13.0. I run this example just fine: var os = require('os');
the output:
|
Environment details
Issue description
In node 10, we saw deprecation notices during the build but node-pty still worked.
As of today's release of Node 12, node-pty no longer builds.
I will take a stab at an update and submit a PR if I have any luck.
The text was updated successfully, but these errors were encountered: