Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable and fix typecast warnings #584

Merged
merged 16 commits into from
Jun 15, 2023
Merged

fix: enable and fix typecast warnings #584

merged 16 commits into from
Jun 15, 2023

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Mar 3, 2023

No description provided.

@rzhao271 rzhao271 self-assigned this Mar 3, 2023
Tyriar
Tyriar previously approved these changes Mar 3, 2023
View reviewed changes
@Tyriar Tyriar added this to the 1.0.0 milestone Mar 3, 2023
deepak1556
deepak1556 requested changes Mar 8, 2023
View reviewed changes
src/win/conpty.cc Outdated Show resolved Hide resolved
src/win/conpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
@Tyriar Tyriar removed this from the 1.0.0 milestone Jun 9, 2023
@rzhao271 rzhao271 mentioned this pull request Jun 12, 2023
Closed
@rzhao271 rzhao271 requested a review from deepak1556 June 13, 2023 00:09
deepak1556
deepak1556 reviewed Jun 13, 2023
View reviewed changes
src/win/winpty.cc Outdated Show resolved Hide resolved
deepak1556
deepak1556 reviewed Jun 13, 2023
View reviewed changes
src/win/conpty.cc Outdated Show resolved Hide resolved
deepak1556
deepak1556 reviewed Jun 13, 2023
View reviewed changes
src/win/winpty.cc Outdated Show resolved Hide resolved
@rzhao271
Strengthen conversion impl, revert back to HANDLE
54dd006 
For now, pid is still a HANDLE, so we can't use OpenProcess with it.
@rzhao271
Use pid instead of handle
6955721
rzhao271
rzhao271 commented Jun 13, 2023
View reviewed changes
src/win/winpty.cc Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
rzhao271
rzhao271 commented Jun 14, 2023
View reviewed changes
src/win/winpty.cc Outdated Show resolved Hide resolved
@rzhao271 rzhao271 added this to the June 2023 milestone Jun 14, 2023
deepak1556
deepak1556 reviewed Jun 14, 2023
View reviewed changes
binding.gyp Outdated Show resolved Hide resolved
src/win/path_util.cc Show resolved Hide resolved
src/win/conpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Outdated Show resolved Hide resolved
src/win/winpty.cc Show resolved Hide resolved
rzhao271 and others added 2 commits June 14, 2023 07:56
@rzhao271 @deepak1556
Update binding.gyp
a7cf63e 
Co-authored-by: Robo <hop2deep@gmail.com>
@rzhao271
Check params, fix mapping
f4a1e84
@rzhao271 rzhao271 changed the title fix: add SpectreMitigation, fix typecast warnings fix typecast warnings Jun 14, 2023
@rzhao271 rzhao271 changed the title fix typecast warnings fix: enable and fix typecast warnings Jun 14, 2023
@rzhao271
Copy link
Contributor Author

I'd also like to adjust PtyStartProcess to not use goto. There's currently some ugly code workarounds to avoid some compile-time errors due to it.

@rzhao271 rzhao271 requested a review from deepak1556 June 14, 2023 20:41
@rzhao271
Copy link
Contributor Author

rzhao271 commented Jun 14, 2023 •
edited
Loading

PR not ready to merge. The kill unit test is flaky.
Edit: It looks like the test times out sometimes. Locally it doesn't work due to an EPIPE error. I'd like to investigate in a future PR considering how it could be my setup. I also noticed that adding logging to some unit tests locally often resulted in other unit tests failing due to EPIPE errors.

deepak1556
deepak1556 reviewed Jun 15, 2023
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can approve once test failures have been resolved.

@rzhao271 rzhao271 requested a review from deepak1556 June 15, 2023 16:21
@rzhao271 rzhao271 merged commit 5278274 into main Jun 15, 2023
9 checks passed
@rzhao271 rzhao271 deleted the rzhao271/binskim branch June 15, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@Tyriar Tyriar Awaiting requested review from Tyriar

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@rzhao271 @deepak1556 @Tyriar