-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable and fix typecast warnings #584
Conversation
5d31f48
to
78afb00
Compare
e3686bc
to
e77a000
Compare
For now, pid is still a HANDLE, so we can't use OpenProcess with it.
Co-authored-by: Robo <hop2deep@gmail.com>
I'd also like to adjust PtyStartProcess to not use goto. There's currently some ugly code workarounds to avoid some compile-time errors due to it. |
PR not ready to merge. The kill unit test is flaky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can approve once test failures have been resolved.
No description provided.