Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add Onefuzz.container.reset to the SDK #198

Merged
merged 6 commits into from
Oct 23, 2020
Merged

Add Onefuzz.container.reset to the SDK #198

merged 6 commits into from
Oct 23, 2020

Conversation

anshuman-goel
Copy link
Contributor

@anshuman-goel anshuman-goel commented Oct 23, 2020 •
edited
Loading

Summary of the Pull Request

To reduce overload for scaling and for testing I need to delete particular set of container. Adding container reset cli argument.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

Also,

  • changing reset --containers to call containers reset
  • sorting types in ContainerType

Validation Steps Performed

Manually tested.

bmc-msft
bmc-msft reviewed Oct 23, 2020
View reviewed changes
src/cli/onefuzz/api.py Outdated Show resolved Hide resolved
anshuman-goel
anshuman-goel commented Oct 23, 2020
View reviewed changes
src/cli/onefuzz/api.py
self, container_types: Optional[List[enums.ContainerType]] = None
) -> None:
"""Reset containers unless specified.
[Caution]: It can lead to unexpected results.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmc-msft The cli is not able to read the lines after first one. Some bug exists over there.

@anshuman-goel anshuman-goel marked this pull request as ready for review October 23, 2020 19:25
@anshuman-goel anshuman-goel mentioned this pull request Oct 23, 2020
Merged
5 tasks
@bmc-msft bmc-msft changed the title Adding Container reset Add Onefuzz.container.reset to the SDK Oct 23, 2020
@bmc-msft bmc-msft merged commit 2fe56f9 into microsoft:main Oct 23, 2020
@bmc-msft bmc-msft mentioned this pull request Oct 23, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmc-msft bmc-msft bmc-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshuman-goel @bmc-msft