You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows-rs is the newer, Microsoft-supported version of the API bindings; winapi hasn't been updated in some time. This allows us to remove some code, as windows-rs includes the Sym* functions that we had to previously defined ourselves in dbghelp.
Rather than port the jobs and com code I removed it, as it was unused.
The check_hr and check_winapi macros have been replaced by use of .ok()? on BOOL and ? on HRESULT which now support standard error handling facilities.
Just cloned this repo and tried to build with winapi v0.3.9. The build (of src\agent\coverage) is broken as synchapi and impl-default aren't enabled. So I guess this PR would be nice as it should happen to fix the build too :)
Just cloned this repo and tried to build with winapi v0.3.9. The build (of src\agent\coverage) is broken as synchapi and impl-default aren't enabled. So I guess this PR would be nice as it should happen to fix the build too :)
The issue here is that it depends on what level in the repo you build at. If you build src/agent then all the features of winapi which we need are enabled, since cargo will union them all together. However, some of the subcrates use features without enabling them (for example, I just fixed one over here), so you might get failures if you build an individual crate. This is annoying to detect in the CI build since we'd have to build each crate individually rather than just building the whole workspace...
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windows-rs
is the newer, Microsoft-supported version of the API bindings;winapi
hasn't been updated in some time. This allows us to remove some code, aswindows-rs
includes theSym*
functions that we had to previously defined ourselves indbghelp
.Rather than port the
jobs
andcom
code I removed it, as it was unused.The
check_hr
andcheck_winapi
macros have been replaced by use of.ok()?
onBOOL
and?
onHRESULT
which now support standard error handling facilities.