Skip to content

Commit

Permalink
update with pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
rachguo authored and rachguo committed Jan 29, 2024
1 parent 5c2837c commit 35dc678
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions tools/ci_build/github/apple/test_apple_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def _test_apple_packages(args):
cwd=target_proj_path,
)

if PackageVariant[args.variant] != PackageVariant.Mobile and not args.test_full_package_with_ios_only:
if PackageVariant[args.variant] != PackageVariant.Mobile and not args.skip_macos_test:
subprocess.run(
[
"xcrun",
Expand Down Expand Up @@ -207,9 +207,10 @@ def parse_args():
)

parser.add_argument(
"--test_full_package_with_ios_only",
"--skip_macos_test",
action="store_true",
help="Run iOS tests only. (Specify this argument only when package variant is Full.)",
help="Skip macos platform tests. Specify this argument when build targets only contain ios archs. "
"(Currently only applies to the build using default_full_ios_framework_build_settings.json config.)",
)

return parser.parse_args()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ stages:
--framework_info_file "$(Build.BinariesDirectory)/ios_framework/xcframework_info.json" \
--c_framework_dir "$(Build.BinariesDirectory)/ios_framework/framework_out" \
--variant Full \
--test_full_package_with_ios_only
--skip_macos_test
displayName: "Test Apple framework"
- task: PublishBuildArtifacts@1
Expand Down

0 comments on commit 35dc678

Please sign in to comment.