Workaround ROCm global pool #15481
Merged
Workaround ROCm global pool #15481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeixuanZuo
reviewed
Apr 18, 2023
PeixuanZuo
reviewed
Apr 18, 2023
PeixuanZuo
reviewed
Apr 18, 2023
PeixuanZuo
reviewed
Apr 18, 2023
kailums
reviewed
Apr 19, 2023
|
LGTM |
|
approve |
cloudhan
force-pushed
the
guangyunhan/workaround-global-pool
branch
from
5c1453d
to
3259bfb
Compare
kailums
approved these changes
Apr 23, 2023
ShukantPal
pushed a commit
to ShukantPal/onnxruntime
that referenced
this pull request
May 7, 2023
Implement global avg/max pool with reduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15482
This also improve the perf for it, comparison is meanless tho, the original impl is incorrect.