[C#] Add missing rocm csharp api #15540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuslepukhin
reviewed
Apr 17, 2023
yuslepukhin
reviewed
Apr 17, 2023
yuslepukhin
reviewed
Apr 17, 2023
|
@yuslepukhin I can run the tests with Microsoft.ML.OnnxRuntime.EndToEndTests cd csharp/test/Microsoft.ML.OnnxRuntime.EndToEndTests
export SKIPNONPACKAGETESTS=ON
export TESTONGPU=ON
export BUILD_SOURCESDIRECTORY=~/onnxruntime
export PACKAGENAME=Microsoft.ML.OnnxRuntime.ROCm
./runtest.sh ~/onnxruntime/build_rocm_nuget/Release/ 1.15.0-dev-20230418-0937-028d8c4749The Make this PR ready to trigger all CI pipelines. I'd plan add CI testing integration in one more PR. You can ignore this one for now |
cloudhan
force-pushed
the
guangyunhan/rocm-csharp
branch
from
7cf9261
to
5d10892
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp-api
branch
from
bb4e9d4
to
d6966f4
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp
branch
from
5d10892
to
1bf8fa5
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp-api
branch
from
d6966f4
to
032704c
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp
branch
from
1bf8fa5
to
d892dc7
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp-api
branch
from
050facb
to
b731a52
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp
branch
from
d892dc7
to
206ae93
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp-api
branch
from
b731a52
to
81bfb66
Compare
cloudhan
force-pushed
the
guangyunhan/rocm-csharp-api
branch
from
81bfb66
to
95e0e42
Compare
cloudhan
commented
May 16, 2023
| @@ -287,6 +287,11 @@ public struct OrtApi | |||
| public IntPtr GetOptionalContainedTypeInfo; | |||
| public IntPtr GetResizedStringTensorElementBuffer; | |||
| public IntPtr KernelContext_GetAllocator; | |||
| public IntPtr GetBuildInfoString; | |||
There was a problem hiding this comment.
backlog: add GetBuildInfoString stub to avoid rocm apis off-by-one problem. #Resolved
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
| std::string options_str = ""; | ||
|
|
||
| while (it != options.end()) { | ||
| if (options_str == "") { |
There was a problem hiding this comment.
Consider using:
for (auto const& [key, val] : options) #Resolved
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
yuslepukhin
reviewed
May 16, 2023
cloudhan
force-pushed
the
guangyunhan/rocm-csharp-api
branch
from
88def42
to
aa2590d
Compare
yuslepukhin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #15535