-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic CSharp packaging support for ROCm EP #15535
Conversation
* | ||
* \param device_id HIP device id, starts from zero. | ||
*/ | ||
ORT_API_STATUS(OrtSessionOptionsAppendExecutionProvider_ROCM, _In_ OrtSessionOptions* options, int device_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an old API, it belongs to the global scope, no struct involved, so there is no need for initializing as in OrtApi
stuct. I am doubt this decl will affect the ABI tho. The API has already been implemented at
onnxruntime/onnxruntime/core/session/provider_bridge_ort.cc
Lines 1557 to 1562 in 9d26f8f
ORT_API_STATUS_IMPL(OrtSessionOptionsAppendExecutionProvider_ROCM, _In_ OrtSessionOptions* options, int device_id) { | |
OrtROCMProviderOptions provider_options{}; | |
provider_options.device_id = device_id; | |
return OrtApis::SessionOptionsAppendExecutionProvider_ROCM(options, &provider_options); | |
} |
devcie_id
API. Subsequent PR adds API for initializing with provider options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7cf9261
to
5d10892
Compare
1bf8fa5
to
d892dc7
Compare
…ly on linux machines
d892dc7
to
206ae93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR mainly fixes building errors when trying to build nupkg for ROCm EP. It also slighly improve the packaging logic so that devlopers can produce the nupkg on linux natively.
This PR mainly fixes building errors when trying to build nupkg for ROCm EP.
It also slighly improve the packaging logic so that devlopers can produce the nupkg on linux natively.