Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Address the concern of append EP throw #15973

Merged
merged 2 commits into from
May 18, 2023
Merged

[C#] Address the concern of append EP throw #15973

merged 2 commits into from
May 18, 2023

Conversation

cloudhan
Copy link
Member

Minor refactor

@cloudhan cloudhan marked this pull request as draft May 17, 2023 01:43
@cloudhan cloudhan changed the base branch from main to guangyunhan/rocm-csharp-api May 17, 2023 01:44
@cloudhan cloudhan requested a review from yuslepukhin May 17, 2023 01:44
@cloudhan cloudhan mentioned this pull request May 17, 2023
Merged
yuslepukhin
yuslepukhin reviewed May 17, 2023
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yuslepukhin
yuslepukhin previously approved these changes May 17, 2023
View reviewed changes
@yuslepukhin yuslepukhin changed the title Address the concern of append EP throw [C#] Address the concern of append EP throw May 17, 2023
Base automatically changed from guangyunhan/rocm-csharp-api to main May 18, 2023 00:15
@cloudhan cloudhan force-pushed the guangyunhan/csharp-append-throw branch from 8b00334 to 9050efb Compare May 18, 2023 00:39
@cloudhan cloudhan marked this pull request as ready for review May 18, 2023 00:40
@cloudhan cloudhan requested a review from yuslepukhin May 18, 2023 00:40
yuslepukhin
yuslepukhin approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@yuslepukhin yuslepukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cloudhan cloudhan merged commit 5a8b892 into main May 18, 2023
@cloudhan cloudhan deleted the guangyunhan/csharp-append-throw branch May 18, 2023 03:53
@skottmckay
Copy link
Contributor

What's the concern? It wasn't mentioned in the PR description or comments in the code. With C# being a managed language won't it call Dispose on options anyway?

@cloudhan
Copy link
Member Author

@skottmckay #15540 (comment) See this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuslepukhin yuslepukhin yuslepukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cloudhan @skottmckay @yuslepukhin