Fix 4 more bad delegates missing the attribute that cause iOS AOT errors at runtime #18390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors at runtime. Add script to detect mismatch, and run in CI and when creating nuget package.
skottmckay
commented
Nov 10, 2023
yuslepukhin
approved these changes
Nov 10, 2023
yuslepukhin
approved these changes
Nov 10, 2023
…arpDelegatesMissingAttribute
This is the standard clang-format behavior I think. The args are aligned, and where they are aligned is based on whether the first arg is on a new line or not. |
mszhanyi
approved these changes
Nov 14, 2023
skottmckay
deleted the
skottmckay/FixMoreCSharpDelegatesMissingAttribute
branch
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
…ors at runtime (microsoft#18390) ### Description <!-- Describe your changes. --> Fix bad delegates. Add script to detect mismatch, and run in CI and when creating nuget package. Ignore whitespace when looking at the diff to the .cs file as clang-format ran. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> microsoft#18363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bad delegates.
Add script to detect mismatch, and run in CI and when creating nuget package.
Ignore whitespace when looking at the diff to the .cs file as clang-format ran.
Motivation and Context
#18363